-
Notifications
You must be signed in to change notification settings - Fork 95
Added Conversation API to JS SDK #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Conversation API to JS SDK #712
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.16 #712 +/- ##
===============================================
Coverage ? 54.84%
===============================================
Files ? 14
Lines ? 330
Branches ? 66
===============================================
Hits ? 181
Misses ? 131
Partials ? 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9e321f0 to
33ece85
Compare
Generated new protos for 1.16 Signed-off-by: Whit Waldo <[email protected]>
WhitWaldo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - thank you for putting all of this together. I just updated the protos to 1.16 on the repo in master. Could you update your PR to ensure all the test pass so we can merge this in for the release?
Thank you!
|
One more thought - I don't think we need both an HTTP and a gRPC implementation as the SDK need only do one of them (typically preferring gRPC as it's typically the more complicated one). |
Signed-off-by: Constantin Chirila <[email protected]>
Signed-off-by: Constantin Chirila <[email protected]>
9197d9a to
e46b472
Compare
So should I remove the HTTP implementation? |
Signed-off-by: Constantin Chirila <[email protected]>
WhitWaldo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - thank you very much for putting this together!
|
@holopin-bot @ConstantinChirila Thank you! Here's a digital badge as a small token of appreciation. |
|
Congratulations @ConstantinChirila, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmi4hugl40003if045jz82xxs This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Description
This PR adds comprehensive support for the Dapr Conversation API to the JavaScript SDK, enabling developers to interact with Large Language Models (LLMs) through Dapr's conversation components. The implementation includes both HTTP and gRPC protocols, complete type definitions, and a working example.
Issue reference
#706
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: