Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: mark fail virtual #40

Closed
wants to merge 1 commit into from

Conversation

ZeroEkkusu
Copy link
Contributor

Motivation

Overriding fail will allow us to halt a test if a condition is not met.

This will prevent the case when a test continues despite errors, causing a chain reaction that triggers a revert in an external contract, which is confusing.

Closes #29

Solution

function fail() internal virtual {

@ZeroEkkusu ZeroEkkusu closed this May 16, 2022
@ZeroEkkusu
Copy link
Contributor Author

This may not be the best solution. I need to think about it more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark fail() function virtual
1 participant