Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear Name and Role for File Type Options in Export Modal #4098

Open
derekjackson-das opened this issue Sep 17, 2024 · 0 comments
Open

Unclear Name and Role for File Type Options in Export Modal #4098

derekjackson-das opened this issue Sep 17, 2024 · 0 comments
Assignees
Labels
a11y Accessibility

Comments

@derekjackson-das
Copy link
Collaborator

Issue Description:
The name for the file type options in the export modal is currently set to "Select an option," which is not descriptive or unique for this button. The purpose of the button is unclear, leading to confusion for users relying on accessible names.

WCAG Criteria:
2.4.6 Headings and Labels - AA

Snippet:

<button data-testid="dropdown-menu" class="btn-neutral focus:ring-offset-ring-offset relative inline-flex w-auto items-center justify-between rounded-md border-border-light bg-header-primary py-2 pl-3 pr-8 text-text-primary transition-all duration-100 ease-in-out hover:bg-header-hover focus:ring-ring-primary" aria-label="Select an option" id="headlessui-listbox-button-:rbi:" type="button" aria-haspopup="listbox" aria-expanded="false" data-headlessui-state=""></button>

Screenshot 2024-09-17 at 4 41 18 PM

Note:
A more accurate name would be "File Type." The visible label above the button should also match the accessible name, so the text above the button should read "File Type" as well.

If reconfiguring with Ariakit components, the select component looks like a viable replacement. See Ariakit Select.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility
Projects
None yet
Development

No branches or pull requests

2 participants