Merge pull request #561 from fatkodima/do-not-swallow-regexp-errors

Do not swallow `config.ignore` regexp errors

Author: danmayer

lib/coverband/configuration.rb

@@ -224,8 +224,6 @@ def search_paths=(path_array)
     def ignore=(ignored_array)
       ignored_array = ignored_array.map { |ignore_str| Regexp.new(ignore_str) }
       @ignore |= ignored_array
-    rescue RegexpError
-      logger.error "an invalid regular expression was passed in, ensure string are valid regex patterns #{ignored_array.join(",")}"
     end
 
     def current_root

test/coverband/configuration_test.rb

@@ -39,16 +39,6 @@ def setup
     assert_equal expected, Coverband.configuration.ignore
   end
 
-  test "ignore catches regex errors" do
-    Coverband.configuration.logger.expects(:error).with("an invalid regular expression was passed in, ensure string are valid regex patterns *invalidRegex*")
-    Coverband.configure do |config|
-      config.ignore = ["*invalidRegex*"]
-    end
-    Coverband::Collectors::Coverage.instance.reset_instance
-    expected = (Coverband::Configuration::IGNORE_DEFAULTS << "config/environments").map { |str| Regexp.new(str) }
-    assert_equal expected, Coverband.configuration.ignore
-  end
-
   test "ignore" do
     Coverband::Collectors::Coverage.instance.reset_instance
     assert !Coverband.configuration.ignore.first.nil?