Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with detekt-hint #88

Open
Mkohm opened this issue Apr 28, 2020 · 2 comments
Open

Integration with detekt-hint #88

Mkohm opened this issue Apr 28, 2020 · 2 comments

Comments

@Mkohm
Copy link

Mkohm commented Apr 28, 2020

Hi!

I am working on a tool for detection of violations on design principles in my master thesis (read more about it https://github.com/Mkohm/detekt-hint), and is looking for an open source project where I can integrate my tool for some feedback and testing. Would you welcome such an integration? It would mean a lot, and I hope it can continue to improve the maintainability of this project.

It only requires creating a configuration file and a new GitHub action. Please let me know if it is of any interest, and I will create a PR with the required changes.

@gianluz
Copy link
Member

gianluz commented Apr 28, 2020

Hi!! To answer your question Danger Kotlin already supports extensions! You should be able to implement your own extension just by creating a brand new plugin!

If i understood well, detekt hint is something that extends detekt right? and add new rules.

I need to know few things, we can probably discuss online if you are on the Kotlin Slack we can discuss there. but a good start will be have a look to this documentation :
https://github.com/danger/kotlin/blob/master/docs/tutorials/plugin_development.html.md
and this plugin I personally wrote:
https://github.com/gianluz/danger-kotlin-android-lint-plugin

and this is a plugin for Detekt someone else wrote
https://github.com/Hazer/danger-detekt-plugin

@Mkohm
Copy link
Author

Mkohm commented Apr 28, 2020

You are correct, detekt hint is an extension of detekt that adds a new ruleset.

Unfortunately, i am not able to create a new extension for Danger to make this integration (at this point, but maybe later).

Yes, i am on the Kotlin Slack. You should find me by searching for Mkohm :)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants