Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0 #13

Open
6 of 10 tasks
f-meloni opened this issue Feb 2, 2019 · 12 comments
Open
6 of 10 tasks

Release 1.0.0 #13

f-meloni opened this issue Feb 2, 2019 · 12 comments

Comments

@f-meloni
Copy link
Member

f-meloni commented Feb 2, 2019

Roadmap to 1.0.0:

  • Make danger-kotlin work with gradle 5.0 (@gianluz is already working on it)
  • Decide what use to distribute danger-kotlin (maybe brew for Mac, but what for Linux?)
  • Change the name of the generated library (no snapshot) (I think @gianluz has some ideas for this)
  • Write documentation
  • Support for Dangerfile path from cliArgs (danger-swift implementation
    #100)
  • Getting Started Tutorial
  • Make a plugin
  • Usage guides
  • Create files on the json files on the tmp folder instead of the current folder
  • Find a way to allow custom GitHub API calls
@orta
Copy link
Member

orta commented Feb 2, 2019

Once there are stubs for docs and stuff, I'll come and help out with the 1.0ing too (specifically around docs, on boarding etc) 👍

@f-meloni
Copy link
Member Author

f-meloni commented Feb 3, 2019

@orta Nice! Thank you :)

@gianluz
Copy link
Member

gianluz commented Feb 3, 2019

opened a PR for the library version name!

@gianluz
Copy link
Member

gianluz commented Feb 3, 2019

update for gradle 5.0: kscript works with the gradle-capsule-plugin that is not maintained anymore, i forked the plugin, and i have uploaded the new plugin on the plugin portal, now is awaiting for approval, when approved i need to open a PR on kscript using the new capsule plugin.

kscripting/kscript#197

@f-meloni
Copy link
Member Author

f-meloni commented Feb 4, 2019

Now that brew has official support for Linux too, it could be the right decision to distribute danger-kotlin with it :)

@orta
Copy link
Member

orta commented Feb 6, 2019

( as ever, be careful of Homebrew as the main installation route for any dev tools http://artsy.github.io/blog/2019/01/05/its-time-to-use-spm/#What.are.the.downsides.of.the.status.quo )

@f-meloni
Copy link
Member Author

f-meloni commented Feb 6, 2019

@orta thanks for the interesting article!
Yes homebrew has the problem of the versioning (installing the tool globally i think would be ok in this case).
My idea was to obviously add different ways to install it, but I don't know what else would be a good option.
We have as dependencies kscript, kotlin, maven, danger-js and gradle, and they are all in brew, this is why I would start from there to have one single command option to install the tool.
And also it allows us to build danger-kt directly on the destination machine (that is what we need because we can not generate single bin for all the platforms)
But would be cool to have another way of installing it, a versioned one! Do you have any suggestions?

@cesards
Copy link

cesards commented Jan 24, 2020

Guys, is this release up to date?

I'm really looking forward to using Danger at my company and I was thinking about contributing as much as I can. There are no "feature-related" issues and the release milestone seems to be updated. How could I help?

@f-meloni @gianluz

@f-meloni
Copy link
Member Author

I think #60 is the real blocker for a 1.0.0 (and a lot of docs :D)

@gianluz
Copy link
Member

gianluz commented Jan 26, 2020

#60 merged

@orta
Copy link
Member

orta commented Feb 10, 2021

It's 2021, is it time to 1.0? 🍡

@f-meloni
Copy link
Member Author

With 1.0.0-beta2 we should be really close to a final release 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants