-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Commit status check associated with the wrong commit in CircleCI + GitHub combination #1423
Comments
I wonder if the call in here is missing the last optional argument depicting what the commit hash is? danger-js/source/runner/Executor.ts Line 363 in 5edb114
Looking at what this code could use: danger-js/source/platforms/github/GitHubAPI.ts Lines 384 to 390 in 5edb114
EDIT: Looking at the codepath this seems to be correct for us. We are not using inline comments but are instead in favor of posting a single comment that Danger keeps up-to-date and using the commit status checks here. The fix looks fairly trivial. I can try doing one if you so prefer. |
@valscion We’re always happy to review PRs fixing issues. This is a collaborative open-source project! |
Describe the bug
Danger associates the commit status check with the latest commit in an open GitHub pull request when running in CircleCI.
This is problematic when the pull request has more Danger runs and the later Danger run completes faster than the original Danger run. This makes the entire pull request status checks red if Danger has failures.
The commit where Danger did complain on purpose had these environment variables:
The commit where Danger didn't complain but which completed sooner than the one that did complain:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Danger should associate the GitHub commit status with the commit that was failing and not with the latest commit in the PR.
If possible, Danger should use the
CIRCLE_SHA1
environment variable to associate the status check with the correct commit.Screenshots
Your Environment
Additional context
N/A
The text was updated successfully, but these errors were encountered: