Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Gitlab] Can't post multiple inline comments #1405

Open
havebeenfitz opened this issue Sep 14, 2023 · 2 comments
Open

[BUG] [Gitlab] Can't post multiple inline comments #1405

havebeenfitz opened this issue Sep 14, 2023 · 2 comments

Comments

@havebeenfitz
Copy link

havebeenfitz commented Sep 14, 2023

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Add 2+ messages with file and line to Dangerfile.swift
  2. Run danger-swift ci on gitlab instance

Expected behavior
The first inline comment is created, then overriden by the second as a general comment

Screenshots

Your Environment
danger-swift 3.17.1

software version
installation method homebrew
Operating System macOS

Additional context
As I understand there is a connected issue fixed for Github. Is it possible to adopt the same fix for Gitlab or is it completely different?

@fbartho
Copy link
Member

fbartho commented Sep 14, 2023

As I understand there is a connected issue for Github. Is it possible to adopt the same fix for Gitlab or is it completely different?

I would certainly examine the linked PR to see if it teaches you anything, but I wouldn’t expect it to necessarily be exactly related. The fundamentals of cross-provider DangerJS behavior has been pretty stable for a long time. GitLab is a relatively newer provider so I’d expect the issue to be in one of these places:

I think more likely, the problem is a misunderstanding about GitLab’s automatic behaviors, for example maybe GitLab has only one “slot” for a line-level comment, which means the last one always wins. In that case, you might be able to preprocess all the line-level comments, and merge all the ones that target the same/file-line into a single comment. (I even believe this is doable in user-space)

@heltoft
Copy link
Contributor

heltoft commented Aug 29, 2024

This should be good now from v12.0.1 of danger-js.
@havebeenfitz Could you potentially verify? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants