Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] substr is deprecated #1400

Closed
david-allan-jones opened this issue Aug 19, 2023 · 4 comments
Closed

[BUG] substr is deprecated #1400

david-allan-jones opened this issue Aug 19, 2023 · 4 comments
Labels
bug help wanted You Can Do This This idea is well spec'd and ready for a PR

Comments

@david-allan-jones
Copy link
Contributor

Describe the bug
There is a call to the deprecated String.prototype.substr inside of github issue template file.

/source/runner/templates/githubIssueTemplate.ts

To Reproduce
I'm currently not aware of any runtime that doesn't still support this function, but it would be wise to remove it in case support gets dropped on some runtimes.

Expected behavior

This should be replaced with a different function like String.prototype.substring.

Your Environment

software version
danger.js 11
node 18
npm n/a
Operating System Ubuntu
@orta
Copy link
Member

orta commented Aug 19, 2023

Seems reasonable, you're welcome to take a look at it

@orta orta added help wanted You Can Do This This idea is well spec'd and ready for a PR labels Aug 19, 2023
@david-allan-jones david-allan-jones mentioned this issue Aug 20, 2023
Merged
@david-allan-jones
Copy link
Contributor Author

PR: #1401

@igorkamyshev
Copy link

Should it be closed since #1401 is merged? 🤔

@fbartho
Copy link
Member

fbartho commented Jul 4, 2024

Thanks @igorkamyshev

@fbartho fbartho closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted You Can Do This This idea is well spec'd and ready for a PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@orta @fbartho @igorkamyshev @david-allan-jones