You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While this does not cause danger to error, it does cause anyone who looks at the output to think danger failed because of a permissions issue, and ignores everything else.
We use the auto created token in GitHub workflows for Danger as it provides the access we need and doesn't have too much access.
To Reproduce
Steps to reproduce the behavior:
Use the CI created GITHUB_TOKEN with danger.
Expected behavior
How can we make this more clear that this is NOT causing any issues. Not sure if it shouldn't show, or someway to display differently that doesn't make the user feel danger failed due to the 403 error.
Screenshots
If applicable, add screenshots to help explain your problem.
Request failed [403]: https://api.github.com/user
Response: {
"message": "Resource not accessible by integration",
"documentation_url": "https://docs.github.com/rest/reference/users#get-the-authenticated-user"
}
Request failed [403]: https://api.github.com/user
Response: {
"message": "Resource not accessible by integration",
"documentation_url": "https://docs.github.com/rest/reference/users#get-the-authenticated-user"
}
Your Environment
software
version
danger.js
11.2.4
node
v19.4.0
npm
9.2.0
Operating System
Ubuntu
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered:
Probably, I think you'd need to look into how the API is called, as I assume it uses octokit for those API calls which would I think is writing the logs there. Could probably special case that specific API call somehow?
Describe the bug
Danger sends errors to the output for failed https://api.github.com/user connections.
While this does not cause danger to error, it does cause anyone who looks at the output to think danger failed because of a permissions issue, and ignores everything else.
We use the auto created token in GitHub workflows for Danger as it provides the access we need and doesn't have too much access.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
How can we make this more clear that this is NOT causing any issues. Not sure if it shouldn't show, or someway to display differently that doesn't make the user feel danger failed due to the 403 error.
Screenshots
If applicable, add screenshots to help explain your problem.
Your Environment
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: