-
Notifications
You must be signed in to change notification settings - Fork 33
Closed
Labels
code qualityNonfunctional improvements to the codebaseNonfunctional improvements to the codebasedependenciesUpdate one or more dependencies versionUpdate one or more dependencies versionreleased
Description
There are various places in the code that would benefit from the use of a modern URL-handling library, such as furl, purl, or yarl. These include:
-
is_same_url()indelete.py (yarl doesn't help here; see Clean up URL parsing inextract_species()inmetadata/util.pyextract_species()#1416 instead)-
get_content_url()indandiapi.py -
get_instance()inutils.py -
is_page2_url()inutils.py -
_get_instance()inutils.py (yarl doesn't help here)joinurl()inutils.pyMost of(I think rewriting this would be more trouble than it's worth)dandi/dandiarchive.py?- implementing the URL validation needed for publications in asset metadata #1308
We should use such a library to improve the code.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
code qualityNonfunctional improvements to the codebaseNonfunctional improvements to the codebasedependenciesUpdate one or more dependencies versionUpdate one or more dependencies versionreleased