Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versioneer isn't recent enough for Python 3.12 #1353

Closed
jwodder opened this issue Nov 8, 2023 · 2 comments
Closed

Versioneer isn't recent enough for Python 3.12 #1353

jwodder opened this issue Nov 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jwodder
Copy link
Member

jwodder commented Nov 8, 2023

The copy of versioneer that dandi-cli bundles is version 0.18, yet a minimum of version 0.19 (or possibly higher?) is needed in order to receive this patch and thus support Python 3.12.

(Personally, I would recommend scrapping versioneer entirely and using versioningit, but I have an obvious bias.)
@jwodder jwodder added the bug Something isn't working label Nov 8, 2023
@jwodder jwodder mentioned this issue Nov 8, 2023
Closed
@jwodder jwodder mentioned this issue Nov 18, 2023
Merged
@yarikoptic
Copy link
Member

in #1330 I was adding some recent snapshot https://github.com/dandi/dandi-cli/pull/1330/files#diff-18304872b75eda292f2b72a449de58182604394b8df4051c42205bb4a005a245L2

- # Version: 0.18
+ # Version: 0.29+8.gf9bbd1b

should be good enough?

I don't mind switching overall to versioningit in general

@jwodder
Copy link
Member Author

jwodder commented Nov 27, 2023

Fixed in #1330.

@jwodder jwodder closed this as completed Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yarikoptic @jwodder