Skip to content

Commit 8a3d88f

Browse files
committed
Test /server-info endpoint in Dockerized environment
1 parent 3655aa1 commit 8a3d88f

File tree

2 files changed

+7
-14
lines changed

2 files changed

+7
-14
lines changed

dandi/tests/test_utils.py

+7-13
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
import inspect
2-
import os
32
import os.path as op
43
from pathlib import Path
54
import time
65
from typing import Iterable, List
6+
from urllib.parse import urlparse, urlunparse
77

88
import pytest
99
import requests
1010
import responses
1111
from semantic_version import Version
1212

13-
from .skip import mark
13+
from .fixtures import DandiAPI
1414
from .. import __version__
1515
from ..consts import DandiInstance, known_instances
1616
from ..exceptions import BadCliVersionError, CliVersionTooOldError
@@ -332,17 +332,11 @@ def test_get_instance_actual_dandi() -> None:
332332
assert inst.api is not None
333333

334334

335-
if "DANDI_REDIRECTOR_BASE" in os.environ:
336-
using_docker = pytest.mark.usefixtures("local_dandi_api")
337-
else:
338-
using_docker = mark.skipif_no_network
339-
340-
341-
@pytest.mark.xfail(reason="https://github.com/dandi/dandi-archive/issues/1045")
342-
@pytest.mark.redirector
343-
@using_docker
344-
def test_server_info() -> None:
345-
r = requests.get(f"{redirector_base}/server-info")
335+
# @pytest.mark.xfail(reason="https://github.com/dandi/dandi-archive/issues/1045")
336+
def test_server_info(local_dandi_api: DandiAPI) -> None:
337+
u = urlparse(local_dandi_api.api_url)
338+
root_url = urlunparse(u[:2] + ("",) * 4)
339+
r = requests.get(f"{root_url}/server-info")
346340
r.raise_for_status()
347341
data = r.json()
348342
assert "version" in data

tox.ini

-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ commands = sphinx-build -E -W -b html source build
4444
addopts = --tb=short --durations=10
4545
markers =
4646
integration
47-
redirector
4847
filterwarnings =
4948
error
5049
ignore:No cached namespaces found .*:UserWarning

0 commit comments

Comments
 (0)