Skip to content

Commit 649d89d

Browse files
authored
Merge pull request #1487 from dandi/fix-docker-host
Fix host used in minio URLs
2 parents 37b6350 + 85f6dd8 commit 649d89d

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

dandi/tests/data/dandiarchive-docker/docker-compose.yml

+5-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,11 @@ services:
2929
DJANGO_MINIO_STORAGE_ENDPOINT: minio:9000
3030
DJANGO_MINIO_STORAGE_SECRET_KEY: minioSecretKey
3131
DJANGO_STORAGE_BUCKET_NAME: django-storage
32-
DJANGO_MINIO_STORAGE_MEDIA_URL: http://localhost:9000/django-storage
32+
# The Minio URL needs to use 127.0.0.1 instead of localhost so that blob
33+
# assets' "S3 URLs" will use 127.0.0.1, and thus tests that try to open
34+
# these URLs via fsspec will not fail on systems where localhost is both
35+
# 127.0.0.1 and ::1.
36+
DJANGO_MINIO_STORAGE_MEDIA_URL: http://127.0.0.1:9000/django-storage
3337
DJANGO_DANDI_SCHEMA_VERSION: ~
3438
DJANGO_DANDI_WEB_APP_URL: http://localhost:8085
3539
DJANGO_DANDI_API_URL: http://localhost:8000

0 commit comments

Comments
 (0)