-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty-ied metadata fields should be removed entirely after meditor #2080
Comments
url is empty |
@mvandenburgh - any ideas how to fix this? i thought we had run into this in a previous issue and addressed it. one could clear everything out and fill it in again without touching the url field, but i recall we had done something about this. |
I have replicated
progression of records❯ curl --silent -X 'GET' 'https://api-staging.dandiarchive.org/api/dandisets/214362/versions/draft/' -H 'accept: application/json' | jq '.contributor'
[
{
"name": "Halchenko, Yaroslav",
"email": "[email protected]",
"roleName": [
"dcite:ContactPerson"
],
"schemaKey": "Person",
"affiliation": [],
"includeInCitation": true
}
]
❯ curl --silent -X 'GET' 'https://api-staging.dandiarchive.org/api/dandisets/214362/versions/draft/' -H 'accept: application/json' | jq '.contributor'
[
{
"url": " ",
"name": "Halchenko, Yaroslav",
"email": "[email protected]",
"roleName": [
"dcite:ContactPerson"
],
"schemaKey": "Person",
"affiliation": [],
"includeInCitation": true
}
]
❯ curl --silent -X 'GET' 'https://api-staging.dandiarchive.org/api/dandisets/214362/versions/draft/' -H 'accept: application/json' | jq '.contributor'
[
{
"url": "",
"name": "Halchenko, Yaroslav",
"email": "[email protected]",
"roleName": [
"dcite:ContactPerson"
],
"schemaKey": "Person",
"affiliation": [],
"includeInCitation": true
}
] so I think meditor needs to clean up (remove) empty fields. To resolve this one in particular, I will go and fixup metadata directly in DB for now. |
I have tried to fix directly in DB via admin interface, but only caused 500. in logs:
attn @dandi/archive-admin happen you see this -- it was me ;-/ I guess someone should fix via GET/fix/PUT |
I was able to resolve this as @satra suggested, but removing this contributor and adding them again, though I would really prefer a solution where empty strings are converted to null |
Thanks all. Will add this to the backlog. |
https://dandiarchive.org/dandiset/001170/draft is failing to validate but I am not sure why: contributor.3: {'url': '', 'name': 'Pirhayatifard, Delaram', 'email': '[email protected]', 'schemaKey': 'Person', 'includeInCitation': True} is not valid under any of the given schemas
The text was updated successfully, but these errors were encountered: