Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to convert substack misses the headings #186

Open
juliomuhlbauer opened this issue Dec 16, 2024 · 3 comments
Open

Trying to convert substack misses the headings #186

juliomuhlbauer opened this issue Dec 16, 2024 · 3 comments

Comments

@juliomuhlbauer
Copy link

juliomuhlbauer commented Dec 16, 2024

For example: https://www.lennysnewsletter.com/p/how-to-kickstart-and-scale-a-marketplace-2e5

When running epub or pdf it misses the headings like this one:

1. Word of mouth
For me, one of the most fascinating learnings from this phase of the research was how impactful word-of-mouth was for early growth of most of today’s biggest marketplace businesses — it was the most important growth channel for over half of the companies. Though this isn’t actually a growth “lever”, it was an enormous growth driver for these companies, and was a strong early signal of Product/Market Fit. Pro tip: If you don’t know what share of your growth is coming from word-of-mouth, you should find out.
@danburzo
Copy link
Owner

danburzo commented Dec 17, 2024

Hi Júlio, I’ve tested the article in Firefox’s reader mode, and I get the same effect, suggesting mozilla/readability is stripping the headings from the content. It’s probably a good idea to open an issue with them. This is a limitation that I’ve tried to highlight in the readme:

The imperative approach Readability takes will not be perfect in each case, especially on HTML pages with atypical markup; you may occasionally notice that it either leaves in superfluous content, or that it strips out parts of the content. You can confirm the problem against Firefox's Reader View. In this case, consider filing an issue on mozilla/readability.

@juliomuhlbauer
Copy link
Author

juliomuhlbauer commented Dec 17, 2024

Thanks, opened an issue: mozilla/readability#928

@juliomuhlbauer
Copy link
Author

juliomuhlbauer commented Dec 26, 2024

Maybe this could be a solution while they don't fix the issue: mozilla/readability#928 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants