-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp the header #213
Comments
+1 |
1 similar comment
+1 |
That's quite a lot of informations. My main wonder is how you would handle smaller screens. This header is way beyond 80 character-wide (looks like 143 to me), it's going to be an issue. If you put that much informations, you need to think about how you will handle smaller screens. On the details themselves, that looks interesting, and I'm mostly +1 on them. |
About content width and smaller screens, that's true. But we're already
quite bad as the process table has a fixed (and large) width.
That should be improved overall, but I'm not sure how at the moment.
|
OK. I had no idea about the look and width of the process table, but it actually makes sense. Then go for it. Sounds like interesting details to add up in the header. |
Hi, First, in the same fashion than top, you could add some interactive commands to enable/disable some infos and save some space. These keys can also turn to command argument so users can alias the command the way they like it. About existing content, it would be useful to add some infos about the caches. In Mem, having the cache size (eg. In regard with the backends, it's a shame we have to compute the total number of connections by summing four lines. Lag with standbys, archiver status and WAL MB/s might be interesting, but I feel they might be hidden by default and enabled interactively. |
Thanks for the inputs ! It's possible to disable some info from the command line and we plan to make it more flexible thru a config file. |
I finally started working on this again. Here is the new header.
This is the new info. It's a lot but everything doesn't have to be displayed all the time :
We recently added a filter option. When appropriate the counters will show information according to the filters (currently we can filter only on a database name). I didn't include the replication lag because it's dependant on the number of standbies. @ioguix @gleu @Krysztophe: do you think some info is missing or unnecessary. |
Nice ! |
A thought : any way to print the size/nbr of temp files? (in big fat red) |
That's a good one. I'll try to squeeze it in there. |
A real screenshot would help to better see what you've done. |
@gleu : screen shot :) |
Real nice. The bigger header is quite crowed though. |
Yes, but you can choose to display any "group" you want. I think the instance info will be displayed by defaut and not the rest. Here is a new screenshot with the tempfiles and waiting query, plus a cheap attempt at making the groups more visible. For now, adding color when a threshold is reached on a metric is not implemented. We lack the facility to do it and it could be something we add when we move to Rich (#261). |
@Krysztophe : The changes have been merged in the master branch feel free to test it and give us feedback. |
It's in. |
Currently, we have those infos in the header part : (the 3 last lines are removed in non local mode)
Detail :
It would be nice to have more:
We also could list the number of wal senders / wal receiver. But I am not convinced that it's usefull in the header. I am also not fond of having logical workers but they are taken from the worker process pool (like parallel workers and maintenance workers) so not having them here could make the info incomplete / misleading.
Note: the availability of these infos depend on the version of PostgreSQL
Example :
EDIT: data from ps = > data from the psutil library
The text was updated successfully, but these errors were encountered: