Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto reloading the config #25

Open
dakyskye opened this issue Oct 9, 2020 · 3 comments
Open

auto reloading the config #25

dakyskye opened this issue Oct 9, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@dakyskye
Copy link
Owner

dakyskye commented Oct 9, 2020

What do you want

A flag (-a and --auto-reload) to make dxhd watch the config file passed for changes, and auto-reload that config on change.

Why

To avoid reloading all the dxhd instances/to get changes applied instantly.

Implementation hints

Use fsnotify for it.

@dakyskye dakyskye added the enhancement New feature or request label Oct 9, 2020
@NotUnlikeTheWaves
Copy link
Collaborator

Currently looking at using the inotify API that is already provided through syscall so it doesn't create another dependency.

@dakyskye
Copy link
Owner Author

dakyskye commented Nov 3, 2020

Probably reserve -a flag for the future, and use -w --watch for this.
Addition to implementation hints: -w should be ignored if -i is passed.

@dakyskye
Copy link
Owner Author

After #39 this can be done easily.

@dakyskye dakyskye added this to the Rewrite of dxhd milestone Jun 18, 2021
@dakyskye dakyskye removed this from the Rewrite of dxhd milestone Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants