-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension not respecting Prettier config #70
Comments
I'm seeing the same issue, starting in version
Edit: The extension's output seems to confirm it's having trouble with prettier:
|
Thanks for the feedback! Please try v7.4.16 and tell me if you still have problems. |
Huzzah, looks like that did it! Thanks for the awesome extension 🚀 |
Yep, seems fixed! Thanks 🎉 |
Unfortunately, I still seem to have this issue with version
|
Hi, could you open a new issue? |
Sure I can open a new issue, just thought it might be better to re-open this one as it seemed related rather than duplicating. I can confirm that the dependencies are installed as they are used by other tools and downgrading the version to |
Here is a basic reproduction https://github.com/Swiftwork/reproduction-tsimport can you confirm if you want to create another issue or re-open this one? |
I've reopened the issue. Thanks! |
Hi @Swiftwork, I've checked your demo project and can confirm your issue is related to yarn and pnp. Could you create a new issue to address it? PS, I'm not familiar with pnp. Could you provide instructions to setup and test if all dependencies are installed and working? |
@daidodo opened issue #72. Yarn works very similarly to npm and instructions can be found here https://yarnpkg.com/getting-started/migration. The reproduction should probably not need any installation to work as it uses the Zero-installs mode, but you can run |
Describe the bug
The extension is not respecting the Prettier config file. In my case it is defined as a
.prettierrc.json
.To Reproduce
The configuration we are using is for Prettier is:
Expected behavior
The following line
84
columns and it does not break theprintWidth
prop of the config file:When formatting the code with VSCode, the line is kept as it should, since it respects Prettier. Furthermore, the sorter should not wrap the line, nor change the
tabWidth
.Actual behavior
When running the extension, the code gets formatted to the following:
As I supose, it breaks the line since it overflows the default
80
columns. Also, it uses atabWidth
of2
, which is not the expected.OS (please complete the following information):
VS Code (please complete the following information):
package.json (please remove any sensitive info)
I'm not allowed to share the
package.json
file..prettierrc/.prettierrc.js/prettier.config.js/.prettierrc.toml
(if any)filename:
.prettierrc.json
Installed VS Code extensions
[Execute
$ code --list-extensions
in terminal to get the list. How to run VS Code from terminal in MacOS]The text was updated successfully, but these errors were encountered: