Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eslint/prettier/editorconfig configuration for quotemark #102

Open
tmcappsph opened this issue Oct 17, 2023 · 4 comments
Open

Use eslint/prettier/editorconfig configuration for quotemark #102

tmcappsph opened this issue Oct 17, 2023 · 4 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tmcappsph
Copy link

Currently, the extension is not using the eslint/prettier/editorconfig configurations for the quotemark configuration. It would be great to include quotemark in the configuration resolution.

@daidodo
Copy link
Owner

daidodo commented Dec 1, 2023

@tmcappsph
Thanks for the feedback!

Could you be specific about the quotemark config in eslint/prettier/editorconfig that you think it should consider?

@tmcappsph
Copy link
Author

tmcappsph commented Dec 3, 2023

@daidodo

For eslint:
quotes: ["error", "<single/double/backtick>"]
https://eslint.org/docs/latest/rules/quotes (This rule was deprecated in ESLint v8.53.0 in favor for https://eslint.style/rules/js/quotes)

For eslint stylistic
@stylistic/js/quotes: ["error", "<single/double/backtick>"]
https://eslint.style/rules/js/quotes

For prettier: singleQuote: <true/false>
https://prettier.io/docs/en/options.html#quotes

For editorconfig: quote_type = <single/double/auto>
https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#ideas-for-domain-specific-properties

Appreciate you looking into this.

@daidodo
Copy link
Owner

daidodo commented Dec 11, 2023

The plugin supported Prettier and editorconfig already but was not working due to a bug.
I fixed it and published a new version v7.6.8.

For eslint config for quote, it's not supported yet. I'll work on it later. Or welcome someone to help.

Thanks!

@tmcappsph
Copy link
Author

Great. Thanks.

@daidodo daidodo self-assigned this Dec 16, 2023
@daidodo daidodo added the bug Something isn't working label Dec 16, 2023
@daidodo daidodo removed their assignment Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants