Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing route / 404 causes "Connection closed." error with dev server #1135

Closed
rmarscher opened this issue Jan 8, 2025 · 3 comments · Fixed by #1136
Closed

Missing route / 404 causes "Connection closed." error with dev server #1135

rmarscher opened this issue Jan 8, 2025 · 3 comments · Fixed by #1136

Comments

@rmarscher
Copy link
Contributor

npm create waku@latest
cd waku-project
npm run dev
open http://localhost:3000/asdf

It hits the root error boundary (which we are discussing removing in #1131) and displays "Connection closed."

If you then

npm run build
npm run start
open http://localhost:8080/asdf

you will see 404 Not Found from our default Hono notFound handler.

That is the expected behavior.

@rmarscher
Copy link
Contributor Author

I can look into this while I work on #1131 unless you already know why the dev server behaves differently. Thanks!

@dai-shi
Copy link
Owner

dai-shi commented Jan 8, 2025

I'll look into it.

@dai-shi
Copy link
Owner

dai-shi commented Jan 8, 2025

Done! #1136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants