fix: Account for the optional equality support of map/seq inside newtypes #5980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
reviewed
Dec 12, 2024
| thingsChanged = true; | ||
| } else if (type.SupportsEquality) { | ||
| // nothing to do | ||
| } else if (type.Normalize() is UserDefinedType userDefinedType) { |
There was a problem hiding this comment.
Why do you need this normalization? I thought that AsMapType and AsSeqType would actually do that.
There was a problem hiding this comment.
This type.Normalize() cuts through any type proxies that may be sitting around the UserDefinedType.
AsMapType and AsSeqType call NormalizeExpand(), which cuts through both proxies and type synonyms. But that's too much, because a type synonym can also have an explicit (==) declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends fix #5973 of issue #5972 to also handle newtypes, subset types, and type synonyms wrapped around map and sequence types.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.