working on #480

Author: Maksim Volkau

src/FastExpressionCompiler/FastExpressionCompiler.cs

@@ -7549,7 +7549,9 @@ private static void CollectCallingTestName()
             /// In case of exception FEC will emit the whole computation to throw exception in the invocation phase</summary>
             public static bool TryInterpretBool(out bool result, Expression expr, CompilerFlags flags)
             {
-                Debug.Assert(expr.Type.IsPrimitive);
+                var exprType = expr.Type;
+                Debug.Assert(exprType.IsPrimitive || exprType.GetUnderlyingNullableTypeOrNull()?.IsPrimitive == true,
+                    "Can reduce the boolean for the expressions of primitive types or for nullable of primitives but found " + expr.Type);
                 result = false;
                 if ((flags & CompilerFlags.DisableInterpreter) != 0)
                     return false;

src/FastExpressionCompiler/TestTools.cs

@@ -38,9 +38,9 @@ public static class TestTools
     static TestTools()
     {
 #if DEBUG
-        // AllowPrintIL = true;
+        AllowPrintIL = true;
         AllowPrintCS = true;
-        // AllowPrintExpression = true;
+        AllowPrintExpression = true;
 #endif
     }
 

test/FastExpressionCompiler.IssueTests/Issue480_Issue480_CLR_detected_an_invalid_program_exception.cs

@@ -0,0 +1,39 @@
+using System;
+
+#if LIGHT_EXPRESSION
+using FastExpressionCompiler.LightExpression.ImTools;
+using static FastExpressionCompiler.LightExpression.Expression;
+namespace FastExpressionCompiler.LightExpression.IssueTests;
+#else
+using System.Linq.Expressions;
+using static System.Linq.Expressions.Expression;
+namespace FastExpressionCompiler.IssueTests;
+#endif
+
+public struct Issue480_CLR_detected_an_invalid_program_exception : ITestX
+{
+    public void Run(TestRun t)
+    {
+        Original_case(t);
+    }
+
+    public void Original_case(TestContext t)
+    {
+        var p1 = Condition(Equal(Constant(true), Constant(true)), Constant(null, typeof(bool?)), Constant(null, typeof(bool?)));
+        var p2 = Condition(Equal(Constant(true), Constant(true)), Constant(null, typeof(bool?)), Constant(null, typeof(bool?)));
+        var exp = Convert(OrElse(p1, p2), typeof(object));
+        var expr = Lambda<Func<object>>(exp);
+
+        expr.PrintCSharp();
+
+        var fs = expr.CompileSys();
+        fs.PrintIL(format: ILDecoder.ILFormat.AssertOpCodes);
+
+        // the compiled function should return default(int), yet it calls reader.GetInt32 instead
+        var a = fs();
+
+        var ff = expr.CompileFast(false);
+        ff.PrintIL(format: ILDecoder.ILFormat.AssertOpCodes);
+        var b = ff();
+    }
+}

test/FastExpressionCompiler.IssueTests/Issue490_Regression_in_compiling_lambdas_with_ref_struct_parameters.cs

@@ -9,7 +9,6 @@
 namespace FastExpressionCompiler.LightExpression.IssueTests;
 #else
 using System.Linq.Expressions;
-using FastExpressionCompiler.ImTools;
 using static System.Linq.Expressions.Expression;
 namespace FastExpressionCompiler.IssueTests;
 #endif

test/FastExpressionCompiler.TestsRunner/Program.cs

@@ -17,10 +17,8 @@ public static void Main()
 
             // ILGeneratorTools.DisableILGeneratorPooling = true;
             // LightExpression.ILGeneratorTools.DisableILGeneratorPooling = true;
-
-            new Issue284_Invalid_Program_after_Coalesce().Run(); // test print cs
-            new Issue440_Errors_with_simplified_Switch_cases().Run(); // test print cs
-
+            // new Issue284_Invalid_Program_after_Coalesce().Run(); // test print cs
+            // new Issue440_Errors_with_simplified_Switch_cases().Run(); // test print cs
             // new LoopTests().Run(); // test print cs
             // new Issue458_Support_TryFault().Run();
             // new Issue127_Switch_is_supported().Run();
@@ -34,7 +32,10 @@ public static void Main()
             // new Issue461_InvalidProgramException_when_null_checking_type_by_ref().Run();
 
 
-            var st = new TestRun();
+            var st = new TestRun(TestFlags.RethrowException);
+
+            // st.Run(new Issue480_CLR_detected_an_invalid_program_exception());
+
 #if NET8_0_OR_GREATER
             st.Run(new Issue487_Fix_ToCSharpString_output_for_boolean_equality_expressions());
             st.Run(new Issue475_Reuse_DynamicMethod_if_possible());