Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dbp 1066 helm charts improvements #776

Open
wants to merge 8 commits into
base: release-1.0
Choose a base branch
from
Open

Dbp 1066 helm charts improvements #776

wants to merge 8 commits into from
+44 −61

Conversation

M-Schiborr
Copy link
Contributor

@M-Schiborr M-Schiborr commented Nov 21, 2024 •
edited
Loading

Provide Configs as helm values and not as 1P Secrets. In combination with https://github.com/dBildungsplattform/spsh-app-release/pull/34

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

@M-Schiborr M-Schiborr requested a review from a team November 21, 2024 10:49
@M-Schiborr M-Schiborr self-assigned this Nov 21, 2024
aimee-889
aimee-889 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@aimee-889 aimee-889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but i would only merge this together with a PR in spsh-app-release, since as long as these are not merged together, a new rollout to infra staging and prod would not run through

@M-Schiborr M-Schiborr changed the base branch from main to release-1.0 November 29, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aimee-889 aimee-889 aimee-889 approved these changes

@kristoff-kiefer kristoff-kiefer Awaiting requested review from kristoff-kiefer

Assignees

@M-Schiborr M-Schiborr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-Schiborr @aimee-889