Spsh 1195 #772
Merged
Spsh 1195 #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
YoussefBouch
requested changes
Nov 28, 2024
src/modules/personenkontext/persistence/dbiam-personenkontext.repo.ts
Outdated
Show resolved
Hide resolved
…repo.ts Co-authored-by: Youssef Bouchara <[email protected]>
Co-authored-by: Youssef Bouchara <[email protected]>
Co-authored-by: Youssef Bouchara <[email protected]>
YoussefBouch
approved these changes
Nov 28, 2024
marode-cap
requested changes
Nov 28, 2024
src/modules/personenkontext/persistence/dbiam-personenkontext.repo.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Marvin Rode (Cap) <[email protected]>
marode-cap
approved these changes
Nov 29, 2024
HKayed
pushed a commit
that referenced
this pull request
Jan 14, 2025
* fix service monitor settings * install prom-client, npm audit fix, creating metrics module * implementing metrics endpoint * implementing dummy gauge values * configure scraping with serviceMonitor * fix linting * fix serviceMonitor config * get metrics * add metrics controller tests * simple tests * add tests for findByRollen * fixing service monitor setting * add test * remove comments * rewrite metrics service test * implementing MetricsGuard * fixing type error * Create metrics.guard.spec.ts * implementing metrics config * adding configService to test * Update config.loader.spec.ts * set test timeout to 20 minutes * add coverage mock metrics guard * fixing metrics controller test * fixing values yaml * removing metrics from api * remove basic auth * fix route * remove metrics secret config * fixing * remove system variables from secrets to configmap * refactor reporter to injectable, refactor scope to repo * ADD INTEGRATION TEST * refactor folder structure * fixing tests * change service monitor interval to 30 min * Update src/modules/personenkontext/persistence/dbiam-personenkontext.repo.ts Co-authored-by: Youssef Bouchara <[email protected]> * Update src/modules/metrics/metrics.controller.ts Co-authored-by: Youssef Bouchara <[email protected]> * Update src/modules/metrics/metrics.controller.ts Co-authored-by: Youssef Bouchara <[email protected]> * PR feedback * fixing test * fix typo * fix typo * Update src/modules/metrics/metrics.controller.ts Co-authored-by: Marvin Rode (Cap) <[email protected]> * implementing query to get all roles with counts * fixing unit tests --------- Co-authored-by: Timo K <[email protected]> Co-authored-by: Youssef Bouchara <[email protected]> Co-authored-by: Marvin Rode (Cap) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.