Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPSH-1137 #750

Merged
merged 37 commits into from
Nov 29, 2024
Merged

SPSH-1137 #750

merged 37 commits into from
Nov 29, 2024

Conversation

he-meyer
Copy link
Contributor

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/SPSH-1137

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

@he-meyer he-meyer self-assigned this Nov 13, 2024
@he-meyer he-meyer requested review from marode-cap, DeFi3298 and tikle-cap and removed request for marode-cap November 13, 2024 08:08
YoussefBouch
YoussefBouch requested changes Nov 21, 2024
View reviewed changes
src/modules/cron/cron.controller.ts Outdated Show resolved Hide resolved
src/modules/service-provider/domain/service-provider.service.ts Outdated Show resolved Hide resolved
src/modules/organisation/persistence/organisation.repository.ts Outdated Show resolved Hide resolved
src/modules/vidis/api/vidis-offer-api.types.ts Outdated Show resolved Hide resolved
src/modules/vidis/vidis.service.ts Show resolved Hide resolved
src/shared/error/organisation.error.ts Outdated Show resolved Hide resolved
src/modules/service-provider/domain/service-provider.service.ts Outdated Show resolved Hide resolved
src/modules/service-provider/domain/service-provider.service.ts Outdated Show resolved Hide resolved
@he-meyer he-meyer merged commit 109cab6 into main Nov 29, 2024
30 checks passed
@he-meyer he-meyer deleted the SPSH-1137 branch November 29, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tikle-cap tikle-cap tikle-cap approved these changes

@DeFi3298 DeFi3298 DeFi3298 approved these changes

@YoussefBouch YoussefBouch YoussefBouch approved these changes

Assignees

@he-meyer he-meyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@he-meyer @YoussefBouch @DeFi3298 @tikle-cap