Skip to content

Module's uninstall doesn't work as it should #1

@d3cim

Description

@d3cim

Describe the bug
DNSCrypt module doesn't remove the internal dnscrypt-proxy folder once removed from Magisk.

To Reproduce
Steps to reproduce the behavior:

  1. Download the latest dnscrypt-proxy-android version
  2. Disable network connections (no internet)
  3. Install the .zip downloaded
  4. Reboot
  5. Open Magisk > Modules > DNSCrypt-Proxy 2 > Remove
  6. Reboot
  7. See dnscrypt-proxy folder still at storage/emulated/0/dnscrypt-proxy path

Expected behavior (i.e. solution)
Once removed the module should remove all of its rests, without leaving the dnscrypt-proxy folder in the internal memory.

Device informations:

  • Android: 11
  • Magisk: 24.1

Additional context

What I know

  • uninstall.sh won't work with /sdcard for some devices because that path isn't mounted until data is decrypted (fixed in #L2-L4).
  • It doesn't work on devices having Android 11 or higher.
  • It work on devices having Android 7 or lower.

What I don't know

  • If it work on Android 8 devices.
  • If it work on Android 9 devices.
  • If it work on Android 10 devices.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions