-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load_table_data changes the table #100
Comments
Hi, Carissa -- This is a fair criticism, and I'm sorry for the confusion. (Thanks for using py4cytoscape!) The structure and control flow for py4cytoscape was taken from RCy3 in large part. Having done that, it's quite possible that RCy3 has the same issue ... or not. I can see that the lines 304 & 308 of RCy3's Tables.R assign the 'data' dataframe an edited value in the same way as py4cytoscape's tables.py line 455. I'm not sure how R works ... I'll find out whether those RCy3 assignments end up creating a local copy of the dataframe. If so, I can follow suit, too. @AlexanderPico @yihangx ... can you take a look at this behavior in RCy3 and let me know?? Thanks! |
Using p4c.load_table_data changes the input table (adding a
row.names
column. This is unexpected.If the column needs to be added, maybe that should be done on a copy?
The text was updated successfully, but these errors were encountered: