test: extend linting to customized test-project eslint config files #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jennifer-shehane
approved these changes
Jun 6, 2025
|
🎉 This PR is included in version 5.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
eslint.config.mjs uses
{ ignores: ['test-project/'] }since most files are directly scaffolded from Cypress, however this means that customized files are also not linted.There are currently some minor formatting differences in example ESLint config files in test-project/eslint-configs compared to how they are shown in the README document.
Change
Extend linting to include:
Make changes using
npx eslint --fix.Manually change test-project/eslint-configs/eslint.globals.mjs to conform to change made by Prettier to embedded JavaScript in Markdown in README > Cypress globals section.
Verification
and confirm that there are no errors reported.