Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for chrome for testing browser #30751

Merged
merged 20 commits into from
Dec 16, 2024

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Dec 11, 2024

Additional details

  • Added Google Chrome for Testing as a new known browser: --browser chrome-for-testing
    • Has a display name of Chrome for Testing
    • For auto-detection:
      • On Mac, is assumed to be at /Applications/Google Chrome for Testing.app
      • On Linux, looks for the chrome binary on the PATH
      • On Windows, looks for the executable here: C:/Program Files (x86)/Google/Chrome for Testing/chrome.exe
  • Renamed the display name for Google Chrome Canary, from Canary to Chrome Canary
  • Renamed appId to bundleId since it is a reference to the CFBundleIdentifier
  • Passed --disable-infobars to ensure the toolbars are removed. This caused the screenshot sizes to go back to what they were before.

Steps to test

  • Download Google Chrome for Testing
  • Place the application in the correct location
  • Verify Cypress shows the browser in the browser selection page
  • Verify passing --browser chrome-for-testing uses the correct browser
  • Place the application in a non-standard location and verify passing the browser path loads the browser correctly (e.g. --browser /path/to/browser)
  • Verify both Chrome and Chrome for Testing show up separately and can be used independently

How has the user experience changed?

Screenshot 2024-12-13 at 3 25 42 PM

PR Tasks

Copy link

cypress bot commented Dec 11, 2024

cypress    Run #58928

Run Properties:  status check passed Passed #58928  •  git commit 5d87c4bd1a: updating svg
Project cypress
Branch Review mschile/chrome_for_testing
Run status status check passed Passed #58928
Run duration 16m 40s
Commit git commit 5d87c4bd1a: updating svg
Committer Matthew Schile
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 26
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 770
View all changes introduced in this branch ↗︎
UI Coverage  66.27%
  Untested elements 26  
  Tested elements 55  
Accessibility  96.2%
  Failed rules  0 critical   4 serious   1 moderate   0 minor
  Failed elements 200  

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked fine for me. A few comments

packages/app/src/debug/LayeredBrowserIcons.vue Outdated Show resolved Hide resolved
packages/server/lib/util/chromium_flags.ts Show resolved Hide resolved
@AtofStryker AtofStryker self-requested a review December 13, 2024 20:43
@AtofStryker AtofStryker self-requested a review December 13, 2024 22:43
@mschile mschile merged commit 0c3c497 into develop Dec 16, 2024
131 of 133 checks passed
@mschile mschile deleted the mschile/chrome_for_testing branch December 16, 2024 17:39
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 17, 2024

Released in 13.17.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.17.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome for Testing - we can't run your tests Google Chrome for testing - version not parsed correctly
4 participants