-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for chrome for testing browser #30751
Merged
Merged
+598
−312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcC399
reviewed
Dec 11, 2024
cypress Run #58928
Run Properties:
|
Project |
cypress
|
Branch Review |
mschile/chrome_for_testing
|
Run status |
Passed #58928
|
Run duration | 16m 40s |
Commit |
5d87c4bd1a: updating svg
|
Committer | Matthew Schile |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
2
|
Pending |
26
|
Skipped |
0
|
Passing |
770
|
View all changes introduced in this branch ↗︎ |
UI Coverage
66.27%
|
|
---|---|
Untested elements |
26
|
Tested elements |
55
|
Accessibility
96.2%
|
|
---|---|
Failed rules |
0 critical
4 serious
1 moderate
0 minor
|
Failed elements |
200
|
jennifer-shehane
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It worked fine for me. A few comments
AtofStryker
reviewed
Dec 13, 2024
AtofStryker
reviewed
Dec 13, 2024
AtofStryker
approved these changes
Dec 13, 2024
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
--browser chrome-for-testing
Chrome for Testing
/Applications/Google Chrome for Testing.app
chrome
binary on thePATH
C:/Program Files (x86)/Google/Chrome for Testing/chrome.exe
Canary
toChrome Canary
appId
tobundleId
since it is a reference to theCFBundleIdentifier
--disable-infobars
to ensure the toolbars are removed. This caused the screenshot sizes to go back to what they were before.Steps to test
--browser chrome-for-testing
uses the correct browser--browser /path/to/browser
)How has the user experience changed?
PR Tasks
cypress-documentation
? docs: add chrome for testing browser cypress-documentation#6038type definitions
?