chore(deps): deduplicate #29974 yarn.lock

[MikeMcC399]

Additional details

Deduplicates yarn.lock following on from Renovate PR:

• chore(deps): update dependency @nrwl/nx-cloud to v18 #29974

using the post-installation command:

yarn run yarn-deduplicate --strategy highest

• Renovate PRs need special manual attention until Renovate PRs may include yarn.lock with mismatched lockfile #30051 is resolved.

Steps to test

Execute

git clean -xfd
yarn
git diff

and confirm that yarn install does not generate any uncommitted differences.

How has the user experience changed?

Developer change only.

PR Tasks

• [na] Have tests been added/updated?
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[jennifer-shehane]

type checks are not happy ☹️

[MikeMcC399]

@jennifer-shehane

type checks are not happy ☹️

I don't have an explanation for why https://app.circleci.com/pipelines/github/cypress-io/cypress/63542/workflows/bed46da9-a920-42d9-91b7-c958d69f8f2c/jobs/2633249

shows failure executing

yarn workspace cypress dtslint

attempting to install TypeScript

Installing to /root/.dts/typescript-installs/3.5...
TypeError: Class extends value #<Object> is not a constructor or null

Running the same command locally is able to install TypeScript and run the tests, although these do output lots of deprecations (see #30063) which were appearing before this PR.

I guess it might be a caching issue in CircleCI, but I can't say for sure.

• As mentioned in dtslint TypeError: DeprecationError: 'originalKeywordKind' #30063 the dtslint version in use is a 4 year old deprecated npm module.

[MikeMcC399]

This error or similar is occurring in multiple tests. This is suspicious as it is the yarn.lock entry for tar which has been deduplicated. I still suspect that caching is responsible.

TypeError: Class extends value #<Object> is not a constructor or null
    at Object.<anonymous> (/root/cypress/node_modules/npm/node_modules/tar/lib/read-entry.js:91:4)

[MikeMcC399]

• Defer to PR chore(deps): update dependency dtslint to v4.2.1 #30065 which is now carrying out the required deduplication due to the added Renovate config.
• Put this PR to draft state for the moment.

[jennifer-shehane]

Maybe this is only happening on contributor PRs for some reason because it's not happening on our internal PRs.

[jennifer-shehane]

Oh, I see what you're saying about the deduping there too. That makes sense. Let me try some things.

[jennifer-shehane]

@AtofStryker is going to take a look at this issue.

[MikeMcC399]

@jennifer-shehane

@AtofStryker is going to take a look at this issue.

That's very good! I haven't been able to locate the root cause. The issue would have come up anyway the next time there was a PR with any dependency changes. This PR has just ended up highlighting the issue a little earlier.

• I've put this PR back in review, since chore(deps): update dependency dtslint to v4.2.1 #30065 turned out to have the same problem.

[AtofStryker]

I can't exactly figure out what is going on here. Going to try bumping the cache in circle as well as sshing into the box to see if I can replicate

[MikeMcC399]

• Deferring to chore: fix CI pipeline issues with deduped tar package #30077 to fix the nx-cloud / tar issue which is causing several tests to fail.