chore: Bump snapbuild packages #30046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -604,6 +604,8 @@ | |||
| "./node_modules/xdg-basedir/index.js", | |||
| "./node_modules/xml2js/lib/xml2js.js", | |||
| "./packages/config/index.js", | |||
| "./packages/config/src/browser.ts", | |||
| "./packages/config/src/index.ts", | |||
There was a problem hiding this comment.
Looks like these were just reordered....
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
bump-snapbuild-deps
|
| Run status |
|
| Run duration | 17m 17s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
210
|
Skipped
|
0
|
Passing
|
11073
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
null%
|
|
|---|---|
|
Untested elements
|
0
|
|
Tested elements
|
0
|
Accessibility
null%
|
|
|---|---|
|
Failed rules
|
0 critical
0 serious
0 moderate
0 minor
|
|
Failed elements
|
0
|
|
@ryanthemanuel I'm thinking this change does have an effect on things 😅 |
|
@jennifer-shehane, the launchpad failures were weird. There was a busy port: https://cloud.cypress.io/projects/ypt4pf/runs/56583/overview/2a8cb34e-979c-4d00-a494-b2f14d8d962a/replay?roarHideRunsWithDiffGroupsAndTags=1&ts=1723741128942.5999&att=1 is it possible that was flake? I'm not sure I've seen it before, but everything now seems to be passing. |
|
@ryanthemanuel Alright welp, the tests were clearly lying. |
ryanthemanuel
approved these changes
Aug 16, 2024
cacieprins
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This bumps the
@cypress/snapbuild-*packages from 1.0.2 to 1.0.3.This update should have no effect as per this Slack conversation. Just want to get them off the list of deps that keep showing up on this list that need update.
Not sure if I need to run some v8 snapshot tasks for this update or not.
Steps to test
Tests should pass
How has the user experience changed?
Should be no difference.
PR Tasks
cypress-documentation?type definitions?