Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress event 'test:after:run' is not fired when before and after hooks both fail #29762

Open
mmisty opened this issue Jun 27, 2024 · 3 comments
Labels
stage: needs investigating Someone from Cypress needs to look at this stale no activity on this issue for a long period type: bug

Comments

@mmisty
Copy link

mmisty commented Jun 27, 2024

Current behavior

Cypress doesn't show any error messages when both before and after hooks have errors.

Desired behavior

Cypress should show error for tests - the one from before hook

Test code to reproduce

Create spec file and run:

describe('before and after hooks failure', () => {
  before('fail before', () => {
    cy.wrap(null).then(() => {
      throw new Error('Failure in before hook');
    });
  });
  
  it('test 1', () => {
    cy.log('test 1');
  });
  
  it('test 2', () => {
    cy.log('test 2');
  });
  
  after('fail after', () => {
    cy.wrap(null).then(() => {
      throw new Error('Failure in after hook');
    });
  });
});

Cypress shows (seems like stuck):
image

Cypress Version

13.12.0

Node version

18.12.0

Operating System

Darwin 21.6.0

Debug Logs

No response

Other

No response

@jennifer-shehane
Copy link
Member

I can recreate this behavior. The tests hang forever via cypress open. However, the tests properly exit via cypress run which is quite strange actually. I was able to recreate this back to v10. The fact that this doesn't happen during cypress run greatly reduces the severity of the issue.

cypress open

Screenshot 2024-06-27 at 11 01 55 AM

cypress run

Screenshot 2024-06-27 at 11 01 37 AM

@jennifer-shehane jennifer-shehane added the stage: needs investigating Someone from Cypress needs to look at this label Jun 27, 2024
@mmisty
Copy link
Author

mmisty commented Jun 27, 2024

Hello @jennifer-shehane, thank you for responding.
Tests are not hanging as I understand - alhough they are shown as hanging - because event is not fired UI cannot show the error.
And also reporting cannot be done properly by third party plugins because this event is not fired.

@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage: needs investigating Someone from Cypress needs to look at this stale no activity on this issue for a long period type: bug
Projects
None yet
Development

No branches or pull requests

3 participants