Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement better technique to detect signal within @cypress/angular-signals test harness #29731

Closed
AtofStryker opened this issue Jun 24, 2024 · 2 comments
Labels
CT Issue related to component testing npm: @cypress/angular @cypress/angular package issues stale no activity on this issue for a long period

Comments

@AtofStryker
Copy link
Contributor

What would you like?

I would like to have a better way to detect Angular signals within the @cypress/angular-signals test harness.

Why is this needed?

Currently, within the @cypress/angular-signals test harness, we determine what type of signal() an angular signal is based on the Symbol(SIGNAL) property and some other expected keys on the object. This isn't instance based or constructor based, since we can't determine the instanceof of a function. However, avoiding to check for arbitrary keys and values and deterministically figuring out what signal() is passed in without interference would be ideal.

Other

No response

@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label Dec 22, 2024
@cypress-app-bot
Copy link
Collaborator

This issue has been closed due to inactivity.

@cypress-app-bot cypress-app-bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CT Issue related to component testing npm: @cypress/angular @cypress/angular package issues stale no activity on this issue for a long period
Projects
None yet
Development

No branches or pull requests

2 participants