Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher > Developing command node index.js fails #29697

Open
MikeMcC399 opened this issue Jun 18, 2024 · 4 comments
Open

Launcher > Developing command node index.js fails #29697

MikeMcC399 opened this issue Jun 18, 2024 · 4 comments
Labels
process: contributing Related to contributing to the Cypress codebase type: chore Work is required w/ no deliverable to end user

Comments

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Jun 18, 2024

Current behavior

packages/launcher/README > Developing instructions fail with
code: 'MODULE_NOT_FOUND'

The instructions are:

To see browsers detected on your machine, just run:

node index.js

The file packages/launcher/index.js does not exist.

Desired behavior

packages/launcher/README > Developing should give working instructions for contributors.

Test code to reproduce

git clone https://github.com/cypress-io/cypress
cd cypress
yarn workspace @packages/launcher install
cd packages/launcher
node index.js

Cypress Version

First reported on version: 13.11.0
Still not fixed in: 13.16.1

Node version

v18.17.1 LTS

Operating System

Ubuntu 22.04.4 LTS

Debug Logs

$ node index.js
node:internal/modules/cjs/loader:1080
  throw err;
  ^

Error: Cannot find module '/home/mike/github/cypress-io/cypress/packages/launcher/index.js'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
    at Module._load (node:internal/modules/cjs/loader:922:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:23:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Node.js v18.17.1

Other

  • The instructions worked until chore: TypeScript 4.2.3 #15646 was merged in Apr 2021 for Cypress 7.0.1
  • Attempting to use node index.ts instead leads to other errors.
@jennifer-shehane
Copy link
Member

Yah I have a feeling a few of these Readmes are out of date. I try to update them when I see something is not right.

@jennifer-shehane jennifer-shehane added process: contributing Related to contributing to the Cypress codebase type: chore Work is required w/ no deliverable to end user labels Jun 18, 2024
@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Yah I have a feeling a few of these Readmes are out of date. I try to update them when I see something is not right.

Unfortunately I don't have the TypeScript skills to work this out on my own. I was hoping I might be able to somehow get closer to fixing the Firefox / Docker / non-root compatibility issue, but I didn't get very far with this. It's not too critical since the workaround is well documented. It would just be nice to sort it out sometime. And to do this, it would be very handy to run the module standalone.

@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label Dec 16, 2024
@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Dec 16, 2024

The issue remains unresolved in Cypress 13.16.1 (499c361).

The file index.js (packages/launcher/index.js), referred to in the instructions, no longer exists.

The instructions continue to fail for the above reason:

yarn workspace @packages/launcher install
cd packages/launcher
node index.js

To resolve the issue, a change needs to be made to

https://github.com/cypress-io/cypress/blob/develop/packages/launcher/README.md#developing

@cypress-app-bot cypress-app-bot removed the stale no activity on this issue for a long period label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process: contributing Related to contributing to the Cypress codebase type: chore Work is required w/ no deliverable to end user
Projects
None yet
Development

No branches or pull requests

3 participants