Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devServerPublicPathRoute omitted from ConfigOptions #29633

Open
trbagley-gresham opened this issue Jun 7, 2024 · 4 comments
Open

devServerPublicPathRoute omitted from ConfigOptions #29633

trbagley-gresham opened this issue Jun 7, 2024 · 4 comments
Labels
CT Issue related to component testing prevent-stale mark an issue so it is ignored by stale[bot] Reproducible Can be reproduced topic: typescript type: bug

Comments

@trbagley-gresham
Copy link

trbagley-gresham commented Jun 7, 2024

Current behavior

When setting devServerPublicPathRoute in defineConfig, TypeScript complains that the property isn't valid despite it being documented.

Desired behavior

TypeScript should accept devServerPublicPathRoute as a valid property of component in defineConfig.

Test code to reproduce

Set devServerPublicPathRoute in cypress.config.ts:

export default defineConfig({
  component: {
    devServer: {
      framework: 'react',
      bundler: 'vite'
    }
  },
  devServerPublicPathRoute: '',
});

Cypress Version

13.11.0

Node version

20.11.1

Operating System

macOS 14.5

Debug Logs

No response

Other

No response

@AtofStryker
Copy link
Contributor

Hi @trbagley-gresham. Thank you for opening an issue. I think this may have been oversight on my end when publicly exposing the option since right now its configured to be an internal option https://github.com/cypress-io/cypress/blob/develop/packages/config/src/options.ts#L530

@jennifer-shehane
Copy link
Member

@AtofStryker Shouldn't this be within the component object of the config? The example shows it as being set outside of the component object.

@trbagley-gresham
Copy link
Author

@jennifer-shehane That's correct, my mistake, although the same happens when devServerPublicPathRoute is placed within the component object. TypeScript tsc doesn't appear to report any issues though.

@jennifer-shehane jennifer-shehane added the CT Issue related to component testing label Jun 10, 2024
@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label Dec 8, 2024
@AtofStryker AtofStryker added prevent-stale mark an issue so it is ignored by stale[bot] and removed stale no activity on this issue for a long period labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CT Issue related to component testing prevent-stale mark an issue so it is ignored by stale[bot] Reproducible Can be reproduced topic: typescript type: bug
Projects
None yet
Development

No branches or pull requests

4 participants