Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the option to ignore chrome prefs #29332

Closed
wants to merge 9 commits into from

Conversation

agentran
Copy link

@agentran agentran commented Apr 15, 2024

Additional details

Steps to test

  1. Define the IGNORE_CHROME_PREFERENCES environment variable to your system
  2. start the cypress server
  3. start a cypress project
  4. close the browser.
  5. relaunch the browser

How has the user experience changed?

There is no change unless you add the environment variable to ignore the chrome preferences

PR Tasks

@CLAassistant
Copy link

CLAassistant commented Apr 15, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@agentran agentran marked this pull request as ready for review April 15, 2024 07:47
@agentran agentran changed the title add the option to ignore chrome prefs feat: add the option to ignore chrome prefs Apr 15, 2024
@agentran agentran force-pushed the ran/feature-29330 branch from 451281e to 8f38188 Compare April 15, 2024 07:49
@agentran agentran closed this Apr 15, 2024
@agentran agentran reopened this Apr 15, 2024
@agentran agentran changed the title feat: add the option to ignore chrome prefs feat: add the option to ignore chrome prefs2 Apr 15, 2024
@agentran agentran changed the title feat: add the option to ignore chrome prefs2 feat: add the option to ignore chrome prefs Apr 15, 2024
@agentran agentran force-pushed the ran/feature-29330 branch from 8f38188 to 6e9f9a5 Compare April 15, 2024 08:03
@jennifer-shehane
Copy link
Member

@agentran I'm going to try to run this branch so that it will build a binary that you'll be able to download and try out to see if this resolves the browser launching issue. If it does, we can look further into how to accommodate this.

@agentran
Copy link
Author

@agentran I'm going to try to run this branch so that it will build a binary that you'll be able to download and try out to see if this resolves the browser launching issue. If it does, we can look further into how to accommodate this.

Hey, No problem, LMK when the binary is available.

@jennifer-shehane
Copy link
Member

@agentran I've remembered that the binaries won't build for contributor PRs so I'll have to pull this out into another PR.

@jennifer-shehane
Copy link
Member

Closing in favor of #29447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to ignore preferences files load on browser relaunch
4 participants