fix: --spec now allows () in filename

[TomasTeixeira2003]

• Closes Cypress doesn't like parenthesis () in filename #28509

Additional details

Even though there was an existing workaround, it is easier to just allow parenthesis.

PR Tasks

• Have tests been added/updated?
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[TomasTeixeira2003]

Is there anything I should do since the check for ''Semantic Pull Request'' is failing?

[jennifer-shehane]

I tested this manually and confirmed that the tests now run when specifying a spec with opening and closing parens.

Before

After

[AtofStryker]

I don't know if we want to escape parenthesis in all cases in cypress. the --spec arg can support glob patterns and parenthesis are a valid glob pattern, but I haven't been able to get glob patterns outside of wildcards to work correctly. @jennifer-shehane do you have more knowledge on what's expected? I mainly going off of https://docs.cypress.io/guides/guides/command-line#cypress-run-spec-lt-spec-gt and testing with the CLI and using https://globster.xyz/

[jennifer-shehane]

@AtofStryker That's a good call out. This bug only happens when you have a closing paren DIRECTLY following an opening paren, so () not (a). I don't think that would be a valid usecase in any globs 🤔 , so escaping them back to back should be fine. That's what I'm thinking.

[AtofStryker]

@jennifer-shehane is the failure in CI legit in relation to the glob changes?

[jennifer-shehane]

@TomasTeixeira2003 There does appear to be a snapshot that has changed with globs - that is failing here. Can you take a look: https://app.circleci.com/pipelines/github/cypress-io/cypress/60955/workflows/e499d77f-ccf3-4aba-8f7f-ed00d2595ba1/jobs/2535654

[TomasTeixeira2003]

I will look into it today

[jennifer-shehane]

@tomasbjerre Any chance to look at this?

[tomasbjerre]

@tomasbjerre Any chance to look at this?

@jennifer-shehane you probably tagged the wrong Tomas. But I think it looks great :)

[jennifer-shehane]

Sorry @TomasTeixeira2003 Any chance to look at this?

[TomasTeixeira2003]

I'm sorry, have had a lot of work lately. By tomorrow I will check it.

[jennifer-shehane]

@TomasTeixeira2003 Just pinging to check in on these updates again.

[jennifer-shehane]

@TomasTeixeira2003 Any chance you'll be able to fix this PR? We'll need to close otherwise.

[TomasTeixeira2003]

I've been working on another feature to rerun failed tests and didn't remember about this. Sorry. By Sunday i will have it working.

[TomasTeixeira2003]

What is the yarn command to run only the system-tests?

[jennifer-shehane]

@TomasTeixeira2003 The instructions are here: https://github.com/cypress-io/cypress/blob/develop/system-tests/README.md

[jennifer-shehane]

Rerunning the tests here

[jennifer-shehane]

@TomasTeixeira2003 There are some linting errors

[TomasTeixeira2003]

And the other ones are flaky?

[jennifer-shehane]

@TomasTeixeira2003 I'm not seeing this fix working anymore when passing the --spec arg. I understand this may be isolated to running Cypress in the local mode, but I can't see the change fixing the issue now with the recent changes. Including a log of what I was running. The test.cy.js file ran, but the test().cy.js file did not run.

[TomasTeixeira2003]

@jennifer-shehane if I pass the spec file without any blackslash before the parenthesis, bash doesn't even accept the command. But if i do it with the backslash it does work.

[jennifer-shehane]

@TomasTeixeira2003 Are you planning to investigate further?

[TomasTeixeira2003]

I don't know what more i can do since my machine allows me to run the spec this way.