-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: unskip previously flaky test #29185
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyrohrbough
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, this skipped test was one of our flakiest ones. Fingers cross it's fixed.
6 failed and 7 flaky tests on run #54788 ↗︎Details:
|
Test | Artifacts | ||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
... > establishes foobar spec bridge |
|
Test | Artifacts | ||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
cy.origin - snapshots > e2e log verification > Does not take snapshots of XHR/fetch requests from secondary origin if the wrong origin is visited / origin mismatch, but instead the primary origin (existing behavior) |
|
Test | Artifacts | |
---|---|---|
App: Runs > Runs - Create Project > when a project is created, injects new projectId into the config file, and sends expected UTM params |
Test Replay
Screenshots
|
error-handling.cy.ts • 2 failed tests • launchpad-e2e
Test | Artifacts | |
---|---|---|
... > automatically sources vite.config.js |
Test Replay
Screenshots
|
|
... > automatically sources webpack.config.js |
Test Replay
Screenshots
|
e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-electron
Test | Artifacts | |
---|---|---|
... > throws when foo cannot resolve |
Test Replay
|
commands/querying/querying.cy.js • 1 flaky test • 5x-driver-chrome
Test | Artifacts | |
---|---|---|
... > throws when alias property isnt a digit or `all` |
Test Replay
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome
Test | Artifacts | |
---|---|---|
... > errors > throws when waiting for 2nd response to route |
Test Replay
|
commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit
Test | Artifacts | |||||||
---|---|---|---|---|---|---|---|---|
network stubbing > intercepting request > can delay and throttle a StaticResponse |
|
Test | Artifacts | |
---|---|---|
... > errors > throws waiting for the 3rd response |
Review all test suite changes for PR #29185 ↗︎ |
This is still very flaky. 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
I noticed in our UI Coverage, that the 'project' input was showing as not tested. I saw that we had skipped this test. Since we've added some better reliability around the App UI tests, I want to unskip this and see if it is still truly flaky.
Steps to test
Tests should pass and not be flaky 🤞🏻 It passed for me locally.
How has the user experience changed?
N/A
PR Tasks
cypress-documentation
?type definitions
?