Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unskip previously flaky test #29185

Closed
wants to merge 10 commits into from
Closed

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Mar 21, 2024

Additional details

I noticed in our UI Coverage, that the 'project' input was showing as not tested. I saw that we had skipped this test. Since we've added some better reliability around the App UI tests, I want to unskip this and see if it is still truly flaky.

Screenshot 2024-03-21 at 2 14 07 PM

Steps to test

Tests should pass and not be flaky 🤞🏻 It passed for me locally.

How has the user experience changed?

N/A

PR Tasks

Copy link
Member

@emilyrohrbough emilyrohrbough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, this skipped test was one of our flakiest ones. Fingers cross it's fixed.

@jennifer-shehane jennifer-shehane marked this pull request as draft March 25, 2024 15:37
@jennifer-shehane jennifer-shehane marked this pull request as ready for review March 29, 2024 20:26
Copy link

cypress bot commented Mar 29, 2024

6 failed and 7 flaky tests on run #54788 ↗︎

6 29127 1325 2 Flakiness 7

Details:

Merge branch 'develop' into unskip-test-2
Project: cypress Commit: 35a7944211
Status: Errored Duration: 20:11 💡
Started: Apr 3, 2024 3:51 PM Ended: Apr 3, 2024 4:11 PM
Failed  e2e/origin/navigation.cy.ts • 1 failed test • 5x-driver-firefox

View Output

Test Artifacts
... > establishes foobar spec bridge
    </td>
  </tr></table>
Failed  e2e/origin/snapshots.cy.ts • 1 failed test • 5x-driver-firefox

View Output

Test Artifacts
cy.origin - snapshots > e2e log verification > Does not take snapshots of XHR/fetch requests from secondary origin if the wrong origin is visited / origin mismatch, but instead the primary origin (existing behavior)
    </td>
  </tr></table>
Failed  runs.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
App: Runs > Runs - Create Project > when a project is created, injects new projectId into the config file, and sends expected UTM params Test Replay Screenshots
Failed  error-handling.cy.ts • 2 failed tests • launchpad-e2e

View Output

Test Artifacts
... > automatically sources vite.config.js Test Replay Screenshots
... > automatically sources webpack.config.js Test Replay Screenshots
Flakiness  e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > throws when foo cannot resolve Test Replay
Flakiness  commands/querying/querying.cy.js • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
... > throws when alias property isnt a digit or `all` Test Replay
Flakiness  commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
... > errors > throws when waiting for 2nd response to route Test Replay
Flakiness  commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit

View Output

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/54788/overview/c8448665-ef7c-40fe-aba7-235cc1dd237b?reviewViewBy=FLAKY&utm_source=github&utm_medium=failed&utm_campaign=view%20test">
        ... > with `resourceType` > can match a proxied image request by resourceType
      </a>
    </td>
    <td>
      
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/54788/overview/9c3de434-7630-4044-8d2b-9df86da2069d?reviewViewBy=FLAKY&utm_source=github&utm_medium=failed&utm_campaign=view%20test">
        ... > stops waiting when an xhr request is canceled
      </a>
    </td>
    <td>
      
    </td>
  </tr></table>
Flakiness  commands/waiting.cy.js • 1 flaky test • 5x-driver-webkit

View Output

Test Artifacts
... > errors > throws waiting for the 3rd response
    </td>
  </tr></table>

Review all test suite changes for PR #29185 ↗︎

@jennifer-shehane
Copy link
Member Author

This is still very flaky. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants