Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after:run - results lost results.status (v13.2) #27926

Closed
DevYimo opened this issue Sep 28, 2023 · 2 comments
Closed

after:run - results lost results.status (v13.2) #27926

DevYimo opened this issue Sep 28, 2023 · 2 comments

Comments

@DevYimo
Copy link

DevYimo commented Sep 28, 2023

Current behavior

With new v13 after:run results lost its status property (results.status === 'finished')

  • is it intentional? I could not find any reason/issue why it was silently removed

Maybe it is not bug?

Thank you :)

Desired behavior

results should have 'status' or smth equivalent?

Test code to reproduce

  1. Run any test
  2. in config - on('after:run', results)
  3. results had? property 'status'
  4. There is nothing like 'status' property

Cypress Version

13.2

Node version

18.12.0

Operating System

Ubuntu

Debug Logs

No response

Other

No response

@jennifer-shehane
Copy link
Member

@DevYimo Can you explain what you were using the results.status = finished property for?

We worked in 13.0 to normalize results, and this property did not seem necessary because at the point that this is run it would always be finished - there are results or there aren't results. It seemed like a redundant check.

@DevYimo
Copy link
Author

DevYimo commented Sep 29, 2023

I just ensured with it, that process is "finished", that's all.
So if it is guaranteed, when there are results, it's finished. I'm ok with that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants