Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout of spec pattern recommendation #21929

Closed
sync-by-unito bot opened this issue May 30, 2022 · 5 comments
Closed

Fix layout of spec pattern recommendation #21929

sync-by-unito bot opened this issue May 30, 2022 · 5 comments
Labels
good first issue Good for newcomers stale no activity on this issue for a long period type: user experience Improvements needed for UX v10.0.0 🐛 Issue present since 10.0.0

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

Summary

Currently the recommendation as you create a spec pattern looks like this:

Screen Shot 2022-05-23 at 12 32 40 PM

Acceptance Criteria

  • The spec pattern should probably appear inline in the warning.
  • There are some other differences from Figma but not sure how new they are, see the field outline, and the positioning of the warning with no space between it and the text field

Screen Shot 2022-05-23 at 12 36 57 PM

Resources

Any Notion documents, Google documents, Figma Boards

┆Issue is synchronized with this Jira Task by Unito
┆Attachments: Screen Shot 2022-05-23 at 12.32.40 PM.png | Screen Shot 2022-05-23 at 12.36.57 PM.png
┆author: Mark Noonan
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1808
┆priority: Low
┆sprint: Backlog
┆taskType: Task

@Manuel-Suarez-Abascal
Copy link
Contributor

I'm assuming this issue is no longer relevant since as of right now it's an error message with different style & message? If so, can we go ahead & close it?

Current UI:
Screenshot 2022-11-26 at 11 04 10 AM

@marktnoonan
Copy link
Contributor

This still happens - it is a slightly different situation than the invalid spec pattern error - an invalid pattern will display this error. A valid filename matching the custom spec pattern will cause this warning to be displayed if the custom spec pattern does not include the recommended .cy.

CC @viniciuspietscher

@marktnoonan
Copy link
Contributor

@jennifer-shehane jennifer-shehane added good first issue Good for newcomers type: user experience Improvements needed for UX v10.0.0 🐛 Issue present since 10.0.0 and removed epic:ui-ux-improvements labels Oct 4, 2023
@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label Apr 2, 2024
@cypress-app-bot
Copy link
Collaborator

This issue has been closed due to inactivity.

@cypress-app-bot cypress-app-bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers stale no activity on this issue for a long period type: user experience Improvements needed for UX v10.0.0 🐛 Issue present since 10.0.0
Projects
None yet
Development

No branches or pull requests

4 participants