Skip to content

Commit c87d02b

Browse files
Merge branch 'develop' into renovate/npm-vitest-vulnerability
2 parents fb8e579 + 695fa95 commit c87d02b

File tree

13 files changed

+39
-16
lines changed

13 files changed

+39
-16
lines changed

.circleci/cache-version.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# Bump this version to force CI to re-create the cache from scratch.
2-
8-19-2025
2+
8-28-2025-dtslint

.circleci/workflows.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ mainBuildFilters: &mainBuildFilters
3838
- /^release\/\d+\.\d+\.\d+$/
3939
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
4040
- 'update-v8-snapshot-cache-on-develop'
41-
- 'chore/updates_post_15'
41+
- 'fix/set_fixed_gtk_version'
4242

4343
# usually we don't build Mac app - it takes a long time
4444
# but sometimes we want to really confirm we are doing the right thing
@@ -49,7 +49,7 @@ macWorkflowFilters: &darwin-workflow-filters
4949
- equal: [ develop, << pipeline.git.branch >> ]
5050
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
5151
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
52-
- equal: [ 'chore/updates_post_15', << pipeline.git.branch >> ]
52+
- equal: [ 'fix/set_fixed_gtk_version', << pipeline.git.branch >> ]
5353
- matches:
5454
pattern: /^release\/\d+\.\d+\.\d+$/
5555
value: << pipeline.git.branch >>
@@ -60,7 +60,7 @@ linuxArm64WorkflowFilters: &linux-arm64-workflow-filters
6060
- equal: [ develop, << pipeline.git.branch >> ]
6161
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
6262
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
63-
- equal: [ 'chore/updates_post_15', << pipeline.git.branch >> ]
63+
- equal: [ 'fix/set_fixed_gtk_version', << pipeline.git.branch >> ]
6464
- matches:
6565
pattern: /^release\/\d+\.\d+\.\d+$/
6666
value: << pipeline.git.branch >>
@@ -83,7 +83,7 @@ windowsWorkflowFilters: &windows-workflow-filters
8383
- equal: [ develop, << pipeline.git.branch >> ]
8484
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
8585
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
86-
- equal: [ 'chore/updates_post_15', << pipeline.git.branch >> ]
86+
- equal: [ 'fix/set_fixed_gtk_version', << pipeline.git.branch >> ]
8787
- matches:
8888
pattern: /^release\/\d+\.\d+\.\d+$/
8989
value: << pipeline.git.branch >>
@@ -157,7 +157,7 @@ commands:
157157
name: Set environment variable to determine whether or not to persist artifacts
158158
command: |
159159
echo "Setting SHOULD_PERSIST_ARTIFACTS variable"
160-
echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "chore/updates_post_15" ]]; then
160+
echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "fix/set_fixed_gtk_version" ]]; then
161161
export SHOULD_PERSIST_ARTIFACTS=true
162162
fi' >> "$BASH_ENV"
163163
# You must run `setup_should_persist_artifacts` command and be using bash before running this command

CONTRIBUTING.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,9 @@ If you do not disable these restrictions for the affected Ubuntu versions, then
261261

262262
#### Windows
263263

264-
When using [`nvm`](https://github.com/coreybutler/nvm-windows) and changing node versions, node install tools are not installed automatically. This is needed for `node-gyp` to rebuild `better-sqlite3`. If you are failing to build Cypress because of this, either with a Python install missing or a VSCode version not being detected by `node-gyp`, you likely need to run the `install_tools.bat` outlined in the [better-sqlite3 troubleshooting guide](https://github.com/WiseLibs/better-sqlite3/blob/master/docs/troubleshooting.md).
264+
Install the current [version of Python](https://devguide.python.org/versions/) (`3.13`) from the [Microsoft Store](https://apps.microsoft.com/store/search?publisher=Python+Software+Foundation) and install the [Visual Studio Community 2022](https://visualstudio.microsoft.com/thank-you-downloading-visual-studio/?sku=Community) edition, selecting the `Desktop development with C++` workload.
265+
266+
Refer to the `node-gyp` [Windows](https://github.com/nodejs/node-gyp/blob/main/README.md#on-windows) documentation section for a description of alternate ways of providing the `node-gyp` execution environment and for troubleshooting information.
265267

266268
#### Corepack
267269

cli/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ _Released 08/26/2025 (PENDING)_
1010
**Bugfixes:**
1111

1212
- Fixed an issue where OS distributions and releases were sometimes not properly populated for Module API results and Cloud recordings. Fixes [#30533](https://github.com/cypress-io/cypress/issues/30533). Addressed in [#32283](https://github.com/cypress-io/cypress/pull/32283).
13+
- Fixed an issue where Cypress would fail to run on GNOME if GTK 4 and GTK 2/3 were detected in the Electron process. Addresses [#32361](https://github.com/cypress-io/cypress/issues/32361).
1314
- Fixed an issue where the open Studio button would incorrectly show for component tests. Addressed in [#32315](https://github.com/cypress-io/cypress/pull/32315).
1415
- Fixed an issue where the TypeScript compiler wasn't being resolved correctly when `@cypress/webpack-batteries-included-preprocessor` was used as a standalone package. Fixes [#32338](https://github.com/cypress-io/cypress/issues/32338).
1516

cli/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,9 @@
129129
"import": "./index.mjs",
130130
"require": "./index.js"
131131
},
132+
"./types/net-stubbing": {
133+
"types": "./types/net-stubbing.d.ts"
134+
},
132135
"./vue": {
133136
"types": "./vue/dist/index.d.ts",
134137
"import": "./vue/dist/cypress-vue.esm-bundler.js",

cli/types/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// Mike Woudenberg <https://github.com/mikewoudenberg>
55
// Robbert van Markus <https://github.com/rvanmarkus>
66
// Nicholas Boll <https://github.com/nicholasboll>
7-
// TypeScript Version: 4.3
7+
// TypeScript Version: 5.0
88
// Updated by the Cypress team: https://www.cypress.io/about/
99

1010
/// <reference path="./cy-blob-util.d.ts" />

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,7 @@
276276
"**/sharp": "0.29.3",
277277
"**/socket.io-parser": "4.0.5",
278278
"**/ua-parser-js": "0.7.33",
279+
"@definitelytyped/typescript-versions": "0.1.7",
279280
"@types/react": "18.3.12",
280281
"browserify-sign": "4.2.2",
281282
"devtools-protocol": "0.0.1459876",

packages/server/lib/util/chromium_flags.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,4 +113,10 @@ export const formatElectronFlags = (flags) => {
113113

114114
export const DEFAULT_CHROME_FLAGS = formatChromeFlags(DEFAULT_FLAGS)
115115

116-
export const DEFAULT_ELECTRON_FLAGS = formatElectronFlags(DEFAULT_CHROME_FLAGS)
116+
export const DEFAULT_ELECTRON_FLAGS = [
117+
...formatElectronFlags(DEFAULT_CHROME_FLAGS),
118+
// NOTE: Can likely be removed with Electron upgrade to 37+.
119+
// @see https://github.com/electron/electron/issues/46538
120+
// @see https://github.com/cypress-io/cypress/issues/32361
121+
...formatElectronFlags(['--gtk-version=3']),
122+
]

packages/server/test/unit/environment_spec.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,16 @@ describe('lib/environment', () => {
4444
return process.env['CYPRESS_INTERNAL_ENV'] = env
4545
})
4646

47+
// @see https://github.com/electron/electron/issues/46538
48+
// @see https://github.com/cypress-io/cypress/issues/32361
49+
context('sets gtk-version=3 in Electron >= 36', () => {
50+
it('sets launch args', () => {
51+
sinon.stub(app.commandLine, 'appendSwitch')
52+
require(`../../lib/environment`)
53+
expect(app.commandLine.appendSwitch).to.have.been.calledWith('--gtk-version', '3')
54+
})
55+
})
56+
4757
context('parses ELECTRON_EXTRA_LAUNCH_ARGS', () => {
4858
let restore = null
4959

tooling/v8-snapshot/cache/darwin/snapshot-meta.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4197,5 +4197,5 @@
41974197
"./tooling/v8-snapshot/cache/darwin/snapshot-entry.js"
41984198
],
41994199
"deferredHashFile": "yarn.lock",
4200-
"deferredHash": "3e86e27d76c3b4b39d481b6197be664677a0e78d04aa91c341520802b31a6467"
4200+
"deferredHash": "777abaab923082d718ebe8969075b9b9563bc3ef90258a0f300f7c6484fddd07"
42014201
}

0 commit comments

Comments
 (0)