From 71576ecfb45cd7ae558e1e1114f30c25de141a41 Mon Sep 17 00:00:00 2001 From: Matthew Schile Date: Thu, 12 Dec 2024 11:37:03 -0700 Subject: [PATCH] update display name --- packages/launcher/__snapshots__/browsers_spec.ts.js | 2 +- packages/launcher/__snapshots__/darwin_spec.ts.js | 2 +- packages/launcher/__snapshots__/windows_spec.ts.js | 4 ++-- packages/launcher/lib/darwin/index.ts | 12 ++++++------ packages/launcher/lib/known-browsers.ts | 2 +- packages/launcher/lib/windows/index.ts | 2 +- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/packages/launcher/__snapshots__/browsers_spec.ts.js b/packages/launcher/__snapshots__/browsers_spec.ts.js index b2b76862ca38..e14c627c0405 100644 --- a/packages/launcher/__snapshots__/browsers_spec.ts.js +++ b/packages/launcher/__snapshots__/browsers_spec.ts.js @@ -34,7 +34,7 @@ exports['browsers returns the expected list of browsers 1'] = [ 'name': 'chrome-for-testing', 'family': 'chromium', 'channel': 'stable', - 'displayName': 'Chrome Test', + 'displayName': 'Chrome for Testing', 'versionRegex': {}, 'binary': 'chrome', 'minSupportedVersion': 64, diff --git a/packages/launcher/__snapshots__/darwin_spec.ts.js b/packages/launcher/__snapshots__/darwin_spec.ts.js index 2ea43b69c8be..0111a4c6c728 100644 --- a/packages/launcher/__snapshots__/darwin_spec.ts.js +++ b/packages/launcher/__snapshots__/darwin_spec.ts.js @@ -58,7 +58,7 @@ exports['darwin browser detection detects browsers as expected 1'] = [ 'name': 'chrome-for-testing', 'family': 'chromium', 'channel': 'stable', - 'displayName': 'Chrome Test', + 'displayName': 'Chrome for Testing', 'versionRegex': {}, 'binary': 'chrome', 'minSupportedVersion': 64, diff --git a/packages/launcher/__snapshots__/windows_spec.ts.js b/packages/launcher/__snapshots__/windows_spec.ts.js index c081762a91d7..5870fa76f37b 100644 --- a/packages/launcher/__snapshots__/windows_spec.ts.js +++ b/packages/launcher/__snapshots__/windows_spec.ts.js @@ -58,7 +58,7 @@ exports['windows browser detection detects browsers as expected 1'] = [ 'name': 'chrome-for-testing', 'family': 'chromium', 'channel': 'stable', - 'displayName': 'Chrome Test', + 'displayName': 'Chrome for Testing', 'versionRegex': {}, 'binary': 'chrome', 'minSupportedVersion': 64, @@ -279,7 +279,7 @@ exports['windows browser detection detects Chrome for Testing 32-bit install 1'] 'name': 'chrome-for-testing', 'family': 'chromium', 'channel': 'stable', - 'displayName': 'Chrome Test', + 'displayName': 'Chrome for Testing', 'versionRegex': {}, 'binary': 'chrome', 'minSupportedVersion': 64, diff --git a/packages/launcher/lib/darwin/index.ts b/packages/launcher/lib/darwin/index.ts index 5ce39651297a..8d4f7ee06c37 100644 --- a/packages/launcher/lib/darwin/index.ts +++ b/packages/launcher/lib/darwin/index.ts @@ -76,18 +76,18 @@ export const browsers: Detectors = { bundleId: 'com.microsoft.Edge', versionProperty: 'CFBundleShortVersionString', }, - canary: { - appName: 'Microsoft Edge Canary.app', - executable: 'Contents/MacOS/Microsoft Edge Canary', - bundleId: 'com.microsoft.Edge.Canary', - versionProperty: 'CFBundleShortVersionString', - }, beta: { appName: 'Microsoft Edge Beta.app', executable: 'Contents/MacOS/Microsoft Edge Beta', bundleId: 'com.microsoft.Edge.Beta', versionProperty: 'CFBundleShortVersionString', }, + canary: { + appName: 'Microsoft Edge Canary.app', + executable: 'Contents/MacOS/Microsoft Edge Canary', + bundleId: 'com.microsoft.Edge.Canary', + versionProperty: 'CFBundleShortVersionString', + }, dev: { appName: 'Microsoft Edge Dev.app', executable: 'Contents/MacOS/Microsoft Edge Dev', diff --git a/packages/launcher/lib/known-browsers.ts b/packages/launcher/lib/known-browsers.ts index 154301e31c58..24c335fe0169 100644 --- a/packages/launcher/lib/known-browsers.ts +++ b/packages/launcher/lib/known-browsers.ts @@ -60,7 +60,7 @@ export const knownBrowsers: Browser[] = [ name: 'chrome-for-testing', family: 'chromium', channel: 'stable', - displayName: 'Chrome Test', + displayName: 'Chrome for Testing', versionRegex: /Google Chrome for Testing (\S+)/m, binary: 'chrome', minSupportedVersion: MIN_CHROME_VERSION, diff --git a/packages/launcher/lib/windows/index.ts b/packages/launcher/lib/windows/index.ts index 50c18b382fb4..e3dcb5bc0dc7 100644 --- a/packages/launcher/lib/windows/index.ts +++ b/packages/launcher/lib/windows/index.ts @@ -116,10 +116,10 @@ const formPaths: WindowsBrowserPaths = { beta: () => { return [normalize('C:/Program Files (x86)/Microsoft/Edge Beta/Application/msedge.exe')] }, + canary: formEdgeCanaryAppPath, dev: () => { return [normalize('C:/Program Files (x86)/Microsoft/Edge Dev/Application/msedge.exe')] }, - canary: formEdgeCanaryAppPath, }, }