Skip to content

Commit 6073426

Browse files
authored
chore: remove binary build step from Linux CI (#27959)
1 parent 59fb48b commit 6073426

File tree

3 files changed

+1
-35
lines changed

3 files changed

+1
-35
lines changed

.circleci/workflows.yml

-20
Original file line numberDiff line numberDiff line change
@@ -1058,25 +1058,6 @@ commands:
10581058
name: "Waiting on Circle CI jobs: <<parameters.job-names>>"
10591059
command: node ./scripts/wait-on-circle-jobs.js --job-names="<<parameters.job-names>>"
10601060

1061-
build-binary:
1062-
steps:
1063-
- run:
1064-
name: Build the Cypress binary
1065-
no_output_timeout: "45m"
1066-
command: |
1067-
source ./scripts/ensure-node.sh
1068-
node --version
1069-
if [[ `node ./scripts/get-platform-key.js` == 'linux-arm64' ]]; then
1070-
# these are missing on Circle and there is no way to pre-install them on Arm
1071-
sudo apt-get update
1072-
sudo apt-get install -y libgtk2.0-0 libgtk-3-0 libgbm-dev libnotify-dev libgconf-2-4 libnss3 libxss1 libasound2 libxtst6 xauth xvfb
1073-
DISABLE_SNAPSHOT_REQUIRE=1 yarn binary-build --version $(node ./scripts/get-next-version.js) --createTar
1074-
else
1075-
yarn binary-build --version $(node ./scripts/get-next-version.js) --createTar
1076-
fi
1077-
- store_artifacts:
1078-
path: cypress-dist.tgz
1079-
10801061
check-if-binary-exists:
10811062
steps:
10821063
- run:
@@ -2106,7 +2087,6 @@ jobs:
21062087
- restore_cached_workspace
21072088
- check-if-binary-exists
21082089
- setup_should_persist_artifacts
2109-
- build-binary
21102090
- trigger-publish-binary-pipeline
21112091

21122092
get-published-artifacts:

scripts/binary/build.ts

+1-9
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import electron from '../../packages/electron'
88
import la from 'lazy-ass'
99
import { promisify } from 'util'
1010
import glob from 'glob'
11-
import tar from 'tar'
1211

1312
import * as packages from './util/packages'
1413
import * as meta from './meta'
@@ -40,7 +39,6 @@ interface BuildCypressAppOpts {
4039
version: string
4140
skipSigning?: boolean
4241
keepBuild?: boolean
43-
createTar?: boolean
4442
}
4543

4644
/**
@@ -78,7 +76,7 @@ async function checkMaxPathLength () {
7876
// For debugging the flow without rebuilding each time
7977

8078
export async function buildCypressApp (options: BuildCypressAppOpts) {
81-
const { platform, version, keepBuild = false, createTar } = options
79+
const { platform, version, keepBuild = false } = options
8280

8381
log('#checkPlatform')
8482
if (platform !== os.platform()) {
@@ -214,12 +212,6 @@ require('./packages/server/index.js')
214212
log('#transformSymlinkRequires')
215213
await transformRequires(meta.distDir())
216214

217-
// optionally create a tar of the `cypress-build` directory. This is used in CI.
218-
if (createTar) {
219-
log('#create tar from dist dir')
220-
await tar.c({ file: 'cypress-dist.tgz', gzip: true, cwd: os.tmpdir() }, ['cypress-build'])
221-
}
222-
223215
log(`#testDistVersion ${meta.distDir()}`)
224216
await testDistVersion(meta.distDir(), version)
225217

scripts/binary/trigger-publish-binary-pipeline.js

-6
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,11 @@ const { getNextVersionForBinary } = require('../get-next-version')
99

1010
const { nextVersion } = await getNextVersionForBinary()
1111

12-
function getArtifactUrl (fileName) {
13-
return `https://output.circle-artifacts.com/output/job/${process.env.CIRCLE_WORKFLOW_JOB_ID}/artifacts/${process.env.CIRCLE_NODE_INDEX}/${fileName}`
14-
}
15-
1612
const body = JSON.stringify({
1713
parameters: {
1814
temp_dir: os.tmpdir(),
1915
sha: process.env.CIRCLE_SHA1,
2016
job_name: process.env.CIRCLE_JOB,
21-
binary_artifact_url: getArtifactUrl('cypress-dist.tgz'),
22-
built_source_artifact_url: getArtifactUrl('cypress-built-source.tgz'),
2317
triggered_workflow_id: process.env.CIRCLE_WORKFLOW_ID,
2418
triggered_job_url: process.env.CIRCLE_BUILD_URL,
2519
branch: process.env.CIRCLE_BRANCH,

0 commit comments

Comments
 (0)