From 5bb9ebc0a854b6d14355c934d82ddf4f244962fe Mon Sep 17 00:00:00 2001 From: AtofStryker Date: Mon, 18 Nov 2024 16:15:41 -0500 Subject: [PATCH] enable justInTimeCompile by default [run ci] --- packages/config/__snapshots__/index.spec.ts.js | 4 ++-- packages/config/src/options.ts | 2 +- packages/config/test/project/utils.spec.ts | 4 ++-- .../__snapshot-html__/EXPERIMENTAL_JIT_COMPILE_REMOVED.html | 2 +- packages/errors/src/errors.ts | 2 +- system-tests/__snapshots__/results_spec.ts.js | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/config/__snapshots__/index.spec.ts.js b/packages/config/__snapshots__/index.spec.ts.js index 1772bbc563d9..e55bbbd1a13b 100644 --- a/packages/config/__snapshots__/index.spec.ts.js +++ b/packages/config/__snapshots__/index.spec.ts.js @@ -48,7 +48,7 @@ exports['config/src/index .getDefaultValues returns list of public config keys 1 'fixturesFolder': 'cypress/fixtures', 'excludeSpecPattern': '*.hot-update.js', 'includeShadowDom': false, - 'justInTimeCompile': false, + 'justInTimeCompile': true, 'keystrokeDelay': 0, 'modifyObstructiveCode': true, 'numTestsKeptInMemory': 50, @@ -138,7 +138,7 @@ exports['config/src/index .getDefaultValues returns list of public config keys f 'fixturesFolder': 'cypress/fixtures', 'excludeSpecPattern': '*.hot-update.js', 'includeShadowDom': false, - 'justInTimeCompile': false, + 'justInTimeCompile': true, 'keystrokeDelay': 0, 'modifyObstructiveCode': true, 'numTestsKeptInMemory': 50, diff --git a/packages/config/src/options.ts b/packages/config/src/options.ts index 09f514a01a8b..114d8464848e 100644 --- a/packages/config/src/options.ts +++ b/packages/config/src/options.ts @@ -233,7 +233,7 @@ const driverConfigOptions: Array = [ requireRestartOnChange: 'server', }, { name: 'justInTimeCompile', - defaultValue: false, + defaultValue: true, validation: validate.isBoolean, requireRestartOnChange: 'server', }, { diff --git a/packages/config/test/project/utils.spec.ts b/packages/config/test/project/utils.spec.ts index ad5db967fe2a..6d72feca5616 100644 --- a/packages/config/test/project/utils.spec.ts +++ b/packages/config/test/project/utils.spec.ts @@ -1084,7 +1084,7 @@ describe('config/src/project/utils', () => { fixturesFolder: { value: 'cypress/fixtures', from: 'default' }, hosts: { value: null, from: 'default' }, includeShadowDom: { value: false, from: 'default' }, - justInTimeCompile: { value: false, from: 'default' }, + justInTimeCompile: { value: true, from: 'default' }, isInteractive: { value: true, from: 'default' }, keystrokeDelay: { value: 0, from: 'default' }, modifyObstructiveCode: { value: true, from: 'default' }, @@ -1202,7 +1202,7 @@ describe('config/src/project/utils', () => { fixturesFolder: { value: 'cypress/fixtures', from: 'default' }, hosts: { value: null, from: 'default' }, includeShadowDom: { value: false, from: 'default' }, - justInTimeCompile: { value: false, from: 'default' }, + justInTimeCompile: { value: true, from: 'default' }, isInteractive: { value: true, from: 'default' }, keystrokeDelay: { value: 0, from: 'default' }, modifyObstructiveCode: { value: true, from: 'default' }, diff --git a/packages/errors/__snapshot-html__/EXPERIMENTAL_JIT_COMPILE_REMOVED.html b/packages/errors/__snapshot-html__/EXPERIMENTAL_JIT_COMPILE_REMOVED.html index bf1e39768bf7..0b9be6897ffc 100644 --- a/packages/errors/__snapshot-html__/EXPERIMENTAL_JIT_COMPILE_REMOVED.html +++ b/packages/errors/__snapshot-html__/EXPERIMENTAL_JIT_COMPILE_REMOVED.html @@ -35,6 +35,6 @@ 
The experimentalJustInTimeCompile configuration option was removed in Cypress version 14.0.0.
-A new justInTimeCompile configuration option is available and is now false by default.
+A new justInTimeCompile configuration option is available and is now true by default.
 You can safely remove this option from your config.
\ No newline at end of file diff --git a/packages/errors/src/errors.ts b/packages/errors/src/errors.ts index f7145d4e4832..b2a799bed413 100644 --- a/packages/errors/src/errors.ts +++ b/packages/errors/src/errors.ts @@ -1242,7 +1242,7 @@ export const AllCypressErrors = { EXPERIMENTAL_JIT_COMPILE_REMOVED: () => { return errTemplate`\ The ${fmt.highlight(`experimentalJustInTimeCompile`)} configuration option was removed in ${fmt.cypressVersion(`14.0.0`)}. - A new ${fmt.highlightSecondary(`justInTimeCompile`)} configuration option is available and is now ${fmt.highlightSecondary(`false`)} by default. + A new ${fmt.highlightSecondary(`justInTimeCompile`)} configuration option is available and is now ${fmt.highlightSecondary(`true`)} by default. You can safely remove this option from your config.` }, // TODO: verify configFile is absolute path diff --git a/system-tests/__snapshots__/results_spec.ts.js b/system-tests/__snapshots__/results_spec.ts.js index 86716f67edad..41df881766d5 100644 --- a/system-tests/__snapshots__/results_spec.ts.js +++ b/system-tests/__snapshots__/results_spec.ts.js @@ -26,7 +26,7 @@ exports['module api and after:run results'] = ` "experimentalMemoryManagement": false, "experimentalModifyObstructiveThirdPartyCode": false, "experimentalSkipDomainInjection": null, - "justInTimeCompile": false, + "justInTimeCompile": true, "experimentalOriginDependencies": false, "experimentalSourceRewriting": false, "experimentalSingleTabRunMode": false,