Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon does not adapt well to light / dark theme change #5433

Open
1 of 6 tasks
MikeMcC399 opened this issue Aug 23, 2023 · 2 comments
Open
1 of 6 tasks

favicon does not adapt well to light / dark theme change #5433

MikeMcC399 opened this issue Aug 23, 2023 · 2 comments
Labels
triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. type: bug

Comments

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Aug 23, 2023

Description

The favicon.svg is supposed to adapt its color depending on the background. That does not work very well in Google Chrome and in some cases the cy letters are not readable.

The worst seems to be if the black theme is selected.

URL of Issue(s)

https://docs.cypress.io/

Steps to replicate

Settings > You and Google > Customize your Chrome profile > Pick a theme color
Settings > Appearance > Theme > Open Chrome Web Store

Browser

First reported on Google Chrome 116
Still reproducible with Google Chrome 128

Device

  • PC
  • Mac
  • iPhone
  • iPad
  • Android Phone
  • Android Tablet

Additional Information

Black

favicon black theme

Warm grey

favicon light theme

@nagash77 nagash77 added the triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. label Aug 24, 2023
@MikeMcC399
Copy link
Contributor Author

The themes in the Chrome Web Store seem to have changed since this issue was first reported, however the issue is still reproducible with Google Chrome 128.

Chrome Settings > Appearance > Reset to default

Selecting the Black & White theme illustrates the issue best
Open https://docs.cypress.io/
Right click open tab and select Duplicate, now shows both light and dark tabs, where the logo is hardly readable on the dark tab.

image

@jennifer-shehane
Copy link
Member

Open to PR here, might require some figma skills or similar though. Our logo pack is on our website: https://www.cypress.io/press-kit#logos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. type: bug
Projects
None yet
Development

No branches or pull requests

4 participants