Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ref in alias example #5334

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

bulatgab
Copy link
Contributor

The existing example from the docs was failing with expected undefined to deeply equal 'blue'.
The new modified test succeeds.

@netlify
Copy link

netlify bot commented Jun 22, 2023

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ab4a378

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2023

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@mike-plummer mike-plummer self-assigned this Jun 22, 2023
Copy link
Contributor

@mike-plummer mike-plummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bulatgab , thanks for the contribution! This looks like a good fix to me - can you get the CLA signed so I can merge?

@bulatgab
Copy link
Contributor Author

bulatgab commented Jun 23, 2023

@mike-plummer Thanks, glad to be helpful!
I signed it right away but it seems not to work.

Screenshot 2023-06-24 at 12 18 47 AM Screenshot 2023-06-24 at 12 19 14 AM

Reported the issue now:
cla-assistant/cla-assistant#957 (comment)

@MikeMcC399
Copy link
Contributor

@bulatgab

Can you check that your e-mail address [email protected] is linked to the GitHub account you are using?

commit ab4a37833eac5df3f7fb817e8bf97fac2af6ef83 (HEAD -> pr/5334, github-desktop-bulatgab/fix-alias-example)
Author: Bulat Gabidullin <[email protected]>
Date:   Thu Jun 22 14:32:39 2023 +0200

@bulatgab
Copy link
Contributor Author

@MikeMcC399 Ah, my bad.
Added that email to my account now.
Thanks!

@mike-plummer
Copy link
Contributor

Thanks for the assist @MikeMcC399, much appreciated!

@mike-plummer mike-plummer merged commit c1e1c0b into cypress-io:main Jun 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants