fix overflowing plugins title and badge #5333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
|
|
@mike-plummer Sorry for the inconvenience! I think this PR is good enough to merge, even if it could possibly be improved on, especially as it is only a cosmetic correction. |
mike-plummer
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
@MikeMcC399 No problem, happens to all of us from time to time 😆 . I agree, good enough and is a definite improvement - can address any nitpicky stuff separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmission of #5320
Closes #5305
This PR adds css property
flex-direction: columnfor the classpluginTitlein src/components/plugins-list/style.module.css, correcting a display issue on https://docs.cypress.io/plugins.The plugin badge (
official,verified,communityorexperimental) is now always displayed below the name of the plugin and it never overflows out of the plugin's box.It also corrects a potential issue which has not been apparent so far, that an unhyphenated plugin name longer than 24 characters would also overflow. This is a consequence of combining
h3withflex.Before
After
Verification
Display https://docs.cypress.io/plugins in Google Chrome / Mozilla Firefox and vary the width of the browser. Ensure that all plugin details stay within the plugin's box.
Temporarily add a 40 character unhyphenated plugin name (e.g.
A234567890B234567890C234567890D234567890) and observe that this name stays inside the box independently of the browser's viewport width.References
cc: @elylucas