Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app notification docs #5324

Merged
merged 7 commits into from
Jun 28, 2023
Merged

app notification docs #5324

merged 7 commits into from
Jun 28, 2023

Conversation

elylucas
Copy link
Contributor

No description provided.

@elylucas elylucas requested a review from jaffrepaul June 19, 2023 22:30
MikeMcC399
MikeMcC399 suggested changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly "MacOS" => "macOS"

see https://support.apple.com/macos

jaffrepaul
jaffrepaul suggested changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@jaffrepaul jaffrepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments/clarifying questions.

@elylucas
Copy link
Contributor Author

Mostly "MacOS" => "macOS"

see https://support.apple.com/macos

Thanks much!

MikeMcC399
MikeMcC399 reviewed Jun 20, 2023
View reviewed changes
Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous comments have all been addressed.
Many thanks 👍🏻

@lmiller1990
Copy link
Contributor

I also wrote this same content in: #5327

Shall we merge these together? I think both has useful content.

@jaffrepaul jaffrepaul merged commit c6ae5bc into main Jun 28, 2023
4 checks passed
@jaffrepaul jaffrepaul deleted the app-notificaitons branch June 28, 2023 17:53
jaffrepaul added a commit that referenced this pull request Jun 28, 2023
@jaffrepaul
Revert "app notification docs (#5324)"
a05c4d0 
This reverts commit c6ae5bc.
@jaffrepaul jaffrepaul restored the app-notificaitons branch June 28, 2023 18:23
@jaffrepaul jaffrepaul mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaffrepaul jaffrepaul jaffrepaul approved these changes

@MikeMcC399 MikeMcC399 MikeMcC399 approved these changes

@pstakoun pstakoun Awaiting requested review from pstakoun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elylucas @lmiller1990 @jaffrepaul @MikeMcC399