Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct contributing test steps #1243

Merged

Conversation

MikeMcC399
Copy link
Collaborator

Issue

When running test steps defined in CONTRIBUTING > Building locally, the command

docker compose run --rm test-factory-all-included

will use an image test-project-test-factory-all-included, if it exists from previous tests, to run new tests. This ignores parameters in factory/.env and so any changed parameters are not tested in this case, leading to unexpected results.

Change

In CONTRIBUTING > Building locally add the --build option to docker compose run, so the command becomes:

docker compose run --build --rm test-factory-all-included

This ensures that a new image test-project-test-factory-all-included is built if any parameters from factory/.env have changed. If no parameters have changed and the Docker cache has been preserved, the image will rebuild from cache.

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 self-assigned this Oct 31, 2024
@MikeMcC399 MikeMcC399 marked this pull request as ready for review October 31, 2024 08:21
@jennifer-shehane jennifer-shehane merged commit ef9aa64 into cypress-io:master Oct 31, 2024
33 checks passed
@MikeMcC399 MikeMcC399 deleted the docs/contributing-test branch October 31, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants