docs: correct contributing test steps #1243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When running test steps defined in CONTRIBUTING > Building locally, the command
will use an image
test-project-test-factory-all-included
, if it exists from previous tests, to run new tests. This ignores parameters in factory/.env and so any changed parameters are not tested in this case, leading to unexpected results.Change
In CONTRIBUTING > Building locally add the
--build
option todocker compose run
, so the command becomes:This ensures that a new image
test-project-test-factory-all-included
is built if any parameters from factory/.env have changed. If no parameters have changed and the Docker cache has been preserved, the image will rebuild from cache.